Pass rspec the right --order option (default or defined).
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RAD should only work with RSpec 3.0+ at this point, so if that can simplify anything please do! |
davidstosik
force-pushed
the
rspec3-order-defined
branch
from
2cbe7d9 to
771567b
Compare
|
@oestrich Done. It's straightforward. |
oestrich
added a commit
that referenced
this pull request
Dec 14, 2015
Pass rspec the right --order option (`default` or `defined`).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I didn't know for sure what exact version the change happened (major > 2?),
I checked inside RSpec::Core::Ordering::Registry.
If we're comfortable with making the switch on version 2 to 3 of RSpec, I can
change the condition to check
Gem.latest_spec_for('rspec-core').version.segments[0].This should fix #192.