Feature/slate generator tweaks #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a better default template name.
|
@oestrich any feedback? |
| def explanation_with_linebreaks | ||
| explanation.gsub "\n", "<br>\n" | ||
| end | ||
|
|
||
| def write |
There was a problem hiding this comment.
With the update to the SlateWriter, I don't think we need this method any more. I deleted it locally and everything passes.
|
You shouldn't see to alter the Gemfile, it's already in the gemspec that gets loaded. I was able to get it running without any Gemfile edits but with the With that update and the |
and changed curl to use shell formatter in slate.
rpocklin
force-pushed
the
feature/slate-generator-tweaks
branch
from
1325f34 to
2228570
Compare
|
Thanks for the quick feedback, appreciate your time. |
|
Sorry about taking a while to get to this. Looks good now. |
|
Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, love the slate generation. Totally awesome.
Here are some tweaks to fix up formatting of sections, explanation and curl to be more idiomatic 'slate'.
I found I couldn't run
rake specwithout making those changes in the Gemfile for 'activesupport' and 'thin' - let me know if this is not needed or there's another way and I can remove the commit from the PR.