Use direct path to rake file #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, we were relying on the Gem's `lib` dir being on the $LOAD_PATH, and thus `load` would find the `tasks/doc.rake` file. This can break when a different gem also has a `tasks/docs.rake` file, and it's further up in the load path. Same goes for a Rails app with a `tasks/docs.rake` file existing. This ensures we get OUR `tasks/docs.rake` file.
stevenharman
force-pushed
the
use_correct_path_to_rake_tasks
branch
from
44ce5ce to
d18a203
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, we were relying on the Gem's
libdir being on the$LOAD_PATH, and thusloadwould find thetasks/doc.rakefile. This can break when a different gem also has atasks/docs.rakefile, and it's further up in the load path. Same goes for a Rails app with atasks/docs.rakefile existing. This ensures we get OURtasks/docs.rakefile.