-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Json classnames to JSON #359
Conversation
Change classnames to capitalize `JSON`
Hi @llenodo thanks for the PR, can you get CI passing and I'll be happy to merge these in. Looks like it just needs the specs to have the updated names. Do you know if this is a change with a later activesupport? Trying to decide if we should restrict on anything with this change since older versions of something will still try the lowercase version. |
Tests are passing now, ran into some issues with JsonIodocsWriter so changed the name back. Could be due to different version of activesupport in the code here vs my project (rails 5.1) |
Thanks! |
For me I think this PR should be reverted and problem investigated with more details. |
I wonder if there was an active support inflection set up in OP's setup. In any case, rather than classifying, you probably want to register the formatter names like I did in AMS https://github.com/rails-api/active_model_serializers/blob/f3a19bd515330751083c0a70b8f57d792de0d788/lib/active_model_serializers/adapter.rb |
The examples in the readme are broken now. I'd prefer if all the formats were the same case, or case insensitive. |
When running the docs:generate command I was getting the following error:
Turned out to be this line in
RspecApiDocumentation::ApiDocumentation
:apparently
"json_writer".classify
is now returningJSONWriter
instead ofJsonWriter
, thus giving the uninitialized constant error