Skip to content

Commit

Permalink
style fix
Browse files Browse the repository at this point in the history
  • Loading branch information
Oliver Zhang committed Jun 22, 2020
1 parent 590be00 commit 8d43a4a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions sdk/include/opentelemetry/sdk/trace/sampler.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ class Sampler
{
public:
// Placeholder
class SpanContext
{};
class SpanContext;
virtual ~Sampler() = default;
/**
* Called during Span creation to make a sampling decision.
Expand All @@ -64,7 +63,7 @@ class Sampler
* the parentContext, unless this is a root span.
* @param name the name of the new Span.
* @param spanKind the trace_api::SpanKind of the Span.
* @param attributes // TODO: Change AttributeKeyValue to common::AttributeKeyValue
* @param attributes TODO: Change AttributeKeyValue to common::AttributeKeyValue
* list of AttributeValue with their keys.
* @param links TODO: Collection of links that will be associated with the Span to be created.
* @return sampling result whether span should be sampled or not.
Expand Down

0 comments on commit 8d43a4a

Please sign in to comment.