Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use the silence operator @ #331

Closed
Tobion opened this issue Jul 26, 2016 · 3 comments
Closed

Do not use the silence operator @ #331

Tobion opened this issue Jul 26, 2016 · 3 comments

Comments

@Tobion
Copy link
Contributor

Tobion commented Jul 26, 2016

You are silencing errors instead of checking for existing indexes, e.g. @$options['analyser'].
This is really bad practice and creates alot of error logs in our app.
Please replace those with isset checks or similar.
@bravo-kernel
Copy link
Collaborator

Feel free to submit a PR mr. @Tobion

hkulekci added a commit to hkulekci/swagger-php that referenced this issue Sep 5, 2016
@hkulekci
changed @ operator as array_key_exists or isset for zircote#331
e4ebf82
@hkulekci hkulekci mentioned this issue Sep 5, 2016
Closed
@hkulekci
Copy link
Contributor

hkulekci commented Sep 5, 2016

@Tobion @bravo-kernel I sent a pr for this issue.

@bfanger
Copy link
Collaborator

bfanger commented Sep 9, 2016

Fix #335 is merged 009dbf7 into master

@bfanger bfanger closed this as completed Sep 9, 2016
bfanger added a commit that referenced this issue Dec 16, 2016
@bfanger
Release 2.0.8
39f4c30 
 - Dynamic Definitions / partial support #301
 - By default only scan *.php files #350
 - Removed silence operator @, improves compatiblity custom errorhandlers #331
 - Additional datetime classes & interfaces #338
 - Fixed case of UNDEFINED constants namespaces, improves hhvm compatibility #319
 - Misc improvements to the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed @ operator as array_key_exists or isset for #331 hkulekci/swagger-php
4 participants
@bfanger @bravo-kernel @hkulekci @Tobion