feat: openapi: 3.1.0 summary and description fields for refs #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bfanger I'll fix the conflicts and review today/tomorrow. |
DerManoMann
force-pushed
the
feature/3.1.0-refs
branch
from
b445f16 to
a94598f
Compare
|
Looking good to me - will be fun merging into PR #1024 but I guess that is my problem :) Speaking of problems - |
|
Ah, forgot to mention that I'd like to merge this and #1024 together and then create 4.1.0 after that unless there is reason that the spec version change to 3.1.0 should be a major version bump. |
DerManoMann
force-pushed
the
feature/3.1.0-refs
branch
from
a94598f to
c314e9f
Compare
DerManoMann
approved these changes
Dec 20, 2021
Closed
DerManoMann
reviewed
Dec 20, 2021
| $defaultValues = get_class_vars(get_class($this)); | ||
| foreach (['summary', 'description'] as $prop) { | ||
| if (property_exists($this, $prop)) { | ||
| if ($this->$prop !== $defaultValues[$prop]) { |
There was a problem hiding this comment.
Just a question: Is there any value in looking up default values this convoluted way? After all we know that Generator::UNDEFINEDis the default value...
swagger-cli does not support 3.1.0
DerManoMann
force-pushed
the
feature/3.1.0-refs
branch
from
c314e9f to
1842adf
Compare
GuilhemN
added a commit
to GuilhemN/swagger-php
that referenced
this pull request
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openapi: 3.1.0refRelated to #885