Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum cleanup #1381

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Enum cleanup #1381

merged 4 commits into from
Jan 13, 2023

Conversation

DerManoMann
Copy link
Collaborator

Fixes #1337

@DerManoMann
Copy link
Collaborator Author

Sorry, got carried away with the cleanup. Key are just ExpandEnums and the slight adjustments to the rules in ExpandEnumsTest

@DerManoMann DerManoMann merged commit ee81477 into zircote:master Jan 13, 2023
@DerManoMann DerManoMann deleted the enum-cleanup branch January 13, 2023 00:51
@momala454
Copy link
Contributor

This is a breaking change, and as far I understand, shouldn't version be changed to 2.0.0 intead of 1.6.0 ?

@momala454
Copy link
Contributor

hello @DerManoMann , what is your opinion ?

@DerManoMann
Copy link
Collaborator Author

Strictly speaking that might be correct. OTOH, it could be considered a bug fix since for the cases change with this PR, the generated spec might be wrong already anyway since you can end up with int values and type string and vice versa.
That is why I thought a minor version bump it is justifiable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How does the engine analyze Enums?
2 participants
@DerManoMann @momala454