More accurately guessing Openapi mistype line and position #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added $context param toDocParser->parse to keep context in exception. According to: - https://github.com/doctrine/annotations/blob/1.7/lib/Doctrine/Common/Annotations/DocParser.php#L440 - https://github.com/doctrine/annotations/blob/1.7/lib/Doctrine/Common/Annotations/DocParser.php#L342
|
Thanks @matiaspub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$context->linepoint to 26 line - method itself. Annotations always placed above the method/class/property/e.t.c.That means we have to move back(decrease
$context->lineto got line of the error in current annotation).I've checked other places, and can't find any place where
$context->linecould be pointed to the line of start annotation.I've checked older PHP versions -
ReflectionMethod::getStartLinealways returned line of the method itself, not line of the method annotation.