Migrate CI from travis to GH action for 2.x #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same CS test that was done in travis.
DerManoMann
reviewed
Sep 6, 2023
composer.json
Outdated
| @@ -34,7 +34,7 @@ | |||
| }, | |||
| "require-dev": { | |||
| "squizlabs/php_codesniffer": ">=2.7", | |||
| "phpunit/phpunit": "^8 || ^9" | |||
| "phpunit/phpunit": "^8.5.23 || ^9" | |||
There was a problem hiding this comment.
Do things really break with earlier 8.x versions?
There was a problem hiding this comment.
With PHP 8.1 and phpunit ^8
PHP Fatal error: Cannot acquire reference to $GLOBALS in /Users/akihito/git/swagger-php/vendor/phpunit/phpunit/src/Util/Configuration.php on line 407
with PHP 8.1 and phpunit ^8.5.20
PHP Fatal error: During inheritance of IteratorAggregate: Uncaught Return type of Symfony\Component\Finder\Finder::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
/Users/akihito/git/swagger-php/vendor/symfony/finder/Finder.php:557
Then I found this advise at stackoverflow. And I set ^8.5.23 and see problem gone.
At this point I didn't think I needed to explore the exact version, but after receiving your comment I tried several times changing the values. Then I found that it seems that the current state of this project is error free at ^8.5.21.
|
Nice one! Thanks @koriym |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test using PHP 7.2 to 8.3 with GH actions.