-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added resolving references of components (not only schemas) #1544
Merged
DerManoMann
merged 10 commits into
zircote:master
from
sapientpro:feat_resolve_refs_for_components
Feb 18, 2024
Merged
feat: Added resolving references of components (not only schemas) #1544
DerManoMann
merged 10 commits into
zircote:master
from
sapientpro:feat_resolve_refs_for_components
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkulyk
changed the title
[feat] Added resolving references of components (not only schemas)
feat: Added resolving references of components (not only schemas)
Jan 30, 2024
DerManoMann
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice!
A couple nits that would be great to fix.
Sorry for taking so long to review.
Co-authored-by: Martin Rademacher <mano@radebatz.net>
DerManoMann
requested changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last bit...
DerManoMann
approved these changes
Feb 18, 2024
Thanks @dkulyk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1542
Added resolving components like header, requestBody and so.
Berole only schemas can be resolved by AugmentRefs