Fixed a bug with inherited properties being null #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a class inherited from another class without docblocks, swagger-php would throw an error, because it was trying to loop through null.
|
👍 |
|
👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a class inherits from another class without docblocks, swagger-php throws an error, because it is trying to loop through null.
I encountered this problem today. My models inherited from a class without a docblock.
When i tried to run
Swagger\scan('/path/to/app'), it greeted me withInvalid argument supplied for foreach(). Not having DocBlocks in a class is certainly not the best thing to do, but it should not stop me from seeing the swagger generated docs.I included a unit test with fixtures. If you comment out the
ifstatement inInheritProperties, you will see, that the unit test fails with said error.