Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for #423 #424

Merged
merged 3 commits into from
Aug 9, 2017
Merged

Fixes for #423 #424

merged 3 commits into from
Aug 9, 2017

Conversation

schodemeiss
Copy link
Contributor

This commit attempts to fix #423 along with additional data in the unit tests to catch this case.

@schodemeiss
Copy link
Contributor Author

@bfanger Any change of a merge of this?

@bfanger bfanger merged commit 56b0d87 into zircote:master Aug 9, 2017
@bfanger
Copy link
Collaborator

bfanger commented Aug 9, 2017

Yes, thanks for your contribution.

@schodemeiss
Copy link
Contributor Author

schodemeiss commented Aug 9, 2017 •
edited
Loading

No problem. Apologies for the nag - just can't produce any swagger docs until this was unblocked. Sorry!
Thanks for a great project.

@bfanger Will there be a release following this so I can pull this via packagist?

bfanger added a commit that referenced this pull request Aug 16, 2017
@bfanger
Released v2.0.11
d010ab6 
- Implemented Swagger->ref(). $swagger->ref('#/info/contact') === $swagger->info->contact
- Added validation of internal refs.
- Misc typos and improved unittests #357, #399, #402, #407, #423, #424
- Misc improvements to the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP notice when yielding anonymous classes implementing interface with trait in source code
2 participants
@schodemeiss @bfanger