Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op): JWT profile verifier with keyset #483

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

muhlemmer
Copy link
Collaborator

@muhlemmer muhlemmer commented Nov 13, 2023

This change allows the creation of a JWTProfile verifier with a implementation of oidc.Keyset instead of a complete storage.

Related to zitadel/zitadel#6809

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #483 (f6bd17e) into main (f014796) will increase coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   60.29%   60.31%   +0.01%     
==========================================
  Files          78       78              
  Lines        6753     6761       +8     
==========================================
+ Hits         4072     4078       +6     
- Misses       2385     2387       +2     
  Partials      296      296              
Files Coverage Δ
pkg/op/verifier_jwt_profile.go 96.92% <77.77%> (-3.08%) ⬇️

@muhlemmer muhlemmer marked this pull request as ready for review November 16, 2023 22:04
@muhlemmer muhlemmer requested review from livio-a and stebenz November 16, 2023 22:04
@stebenz stebenz merged commit a8ef8de into main Nov 21, 2023
8 checks passed
@stebenz stebenz deleted the perf-introspection branch November 21, 2023 09:26
Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants