Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(passkeys): register #29

Merged
merged 36 commits into from
Jul 4, 2023
Merged

feat(passkeys): register #29

merged 36 commits into from
Jul 4, 2023

Conversation

peintnermax
Copy link
Member

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Jest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

@vercel
Copy link

vercel bot commented Jun 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 11:11am

@peintnermax peintnermax mentioned this pull request Jun 8, 2023
Closed
7 tasks
@peintnermax peintnermax marked this pull request as ready for review June 19, 2023 14:52
eliobischof
eliobischof requested changes Jun 21, 2023
View reviewed changes
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Did you check against the ready for review criteria? For example, there are quite some console.logs and outcommented code.
  • If something needs to be changed, please check other occurrences. I didn't repeat the comments.
  • I can't run it locally
    image

apps/login/app/(login)/accounts/page.tsx Outdated Show resolved Hide resolved
apps/login/app/(login)/passkey/add/page.tsx Outdated Show resolved Hide resolved
apps/login/app/(login)/passkey/add/page.tsx Outdated Show resolved Hide resolved
apps/login/ui/SetPasswordForm.tsx Outdated Show resolved Hide resolved
apps/login/app/(login)/register/page.tsx Show resolved Hide resolved
apps/login/lib/zitadel.ts Outdated Show resolved Hide resolved
apps/login/lib/zitadel.ts Outdated Show resolved Hide resolved
apps/login/ui/Info.tsx Outdated Show resolved Hide resolved
apps/login/ui/RegisterFormWithoutPassword.tsx Outdated Show resolved Hide resolved
apps/login/ui/RegisterFormWithoutPassword.tsx Outdated Show resolved Hide resolved
peintnermax and others added 2 commits June 21, 2023 06:59
@peintnermax @eliobischof
Update apps/login/app/(login)/passkey/add/page.tsx
4643e9a 
Co-authored-by: Elio Bischof <elio@zitadel.com>
@peintnermax @eliobischof
Update apps/login/app/(login)/accounts/page.tsx
6431ea0 
Co-authored-by: Elio Bischof <elio@zitadel.com>
peintnermax and others added 3 commits June 21, 2023 07:05
@peintnermax @eliobischof
Update apps/login/ui/SetPasswordForm.tsx
9edfdc8 
Co-authored-by: Elio Bischof <elio@zitadel.com>
@peintnermax @eliobischof
Update apps/login/app/session/route.ts
3a729bb 
Co-authored-by: Elio Bischof <elio@zitadel.com>
@peintnermax @eliobischof
Update apps/login/ui/RegisterFormWithoutPassword.tsx
793814c 
Co-authored-by: Elio Bischof <elio@zitadel.com>
eliobischof
eliobischof reviewed Jun 28, 2023
View reviewed changes
acceptance/docker-compose.yaml Outdated Show resolved Hide resolved
apps/login/app/(login)/passkey/add/page.tsx Outdated Show resolved Hide resolved
apps/login/app/passkeys/route.ts Show resolved Hide resolved
apps/login/lib/zitadel.ts Outdated Show resolved Hide resolved
apps/login/ui/RegisterPasskey.tsx Outdated Show resolved Hide resolved
apps/login/ui/UserAvatar.tsx Outdated Show resolved Hide resolved
eliobischof
eliobischof reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stll have this error
image

@peintnermax
Copy link
Member Author

peintnermax commented Jun 29, 2023 •
edited
Loading

I stll have this error image

Thats because you are not allowed to go to passkey/add without an active session

@peintnermax peintnermax merged commit c252379 into main Jul 4, 2023
@peintnermax peintnermax deleted the passkey-registration branch July 4, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof eliobischof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peintnermax @eliobischof