-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Samsung OneUI #122
Add Samsung OneUI #122
Conversation
Wow! This is huge!!! Thank you for this :)) |
Demo video: Screen_Recording_20230416_133541_Theme_Park.mp4 |
https://www.androidpolice.com/how-to-use-custom-icon-packs-on-samsung-one-ui-4/
Looks like some One UI version detection is necessary. I'll gradually update my old Samsung through One UI 1, 2, 3, 4 and 5 and see where the "Icon" option starts appearing in Theme Park, just to cross-check what that article says. Edit: Samsung is torturing me. There's no way to determine the One UI version. While there's a property Edit 2: So OneUI 4.0 was introduced in a bundle with Android 12. That means on an Android 11 device we would be sure that the Theme Park workaround is not working, and could display a corresponding message. |
Samsung's OneUI launcher version is tightly coupled to the Android OS version. Starting OneUI 3.1.1, icon theming is supported on Android 11, foldable devices only[1] Starting OneUI 4.0, icon theming is supported on all Android 12 devices[2] Sadly it's impossible to detect the OneUI version programmatically[3]. Technically it's incorrect to report all Android 11 devices as incompatible but the only other option is to try and list out all device models individually. This commit adds the display of a "please update to Android 12" message to anyone running Android 11 or lower, and display step-by-step theming instructions to everyone else. [1] https://www.androidpolice.com/how-to-use-custom-icon-packs-on-samsung-one-ui-4/ [2] https://en.wikipedia.org/wiki/One_UI#One_UI_4_2 [3] zixpo#122 (comment)
This commit adds functionality to detect Samsung OneUI launcher and gives instructions to apply third-party icon packs with the help of the free app "Theme Park". Samsung's OneUI launcher version is tightly coupled to the Android OS version. Starting OneUI 3.1.1, icon theming is supported on Android 11, foldable devices only[1] Starting OneUI 4.0, icon theming is supported on all Android 12 devices[2] Sadly it's impossible to detect the OneUI version programmatically[3]. Technically it's incorrect to report all Android 11 devices as incompatible but the only other option is to try and list out all device models individually. This commit adds the display of a "please update to Android 12" message to anyone running Android 11 or lower, and display step-by-step theming instructions to everyone else. [1] https://www.androidpolice.com/how-to-use-custom-icon-packs-on-samsung-one-ui-4/ [2] https://en.wikipedia.org/wiki/One_UI#One_UI_4_2 [3] zixpo#122 (comment)
061fdad
to
687d24b
Compare
@sarsamurmu this is now ready for review. I falsely tell users of foldable Samsung devices on Android 11 that their OneUI version is incompatible but as there is no way to detect the OneUI version programmatically, and as non-foldable devices on Android 11 are definitely not compatible, this was the best I could do. Screenshots and demo video included in the comments. I'm releasing this to my own users this week and will report back if I spot issues. |
This commit adds functionality to detect Samsung OneUI launcher and gives instructions to apply third-party icon packs with the help of the free app "Theme Park". Samsung's OneUI launcher version is tightly coupled to the Android OS version. Starting OneUI 3.1.1, icon theming is supported on Android 11, foldable devices only[1] Starting OneUI 4.0, icon theming is supported on all Android 12 devices[2] Sadly it's impossible to detect the OneUI version programmatically[3]. Technically it's incorrect to report all Android 11 devices as incompatible but the only other option is to try and list out all device models individually. This commit adds the display of a "please update to Android 12" message to anyone running Android 11 or lower, and display step-by-step theming instructions to everyone else. [1] https://www.androidpolice.com/how-to-use-custom-icon-packs-on-samsung-one-ui-4/ [2] https://en.wikipedia.org/wiki/One_UI#One_UI_4_2 [3] zixpo#122 (comment)
687d24b
to
f3a7520
Compare
This commit adds functionality to detect Samsung OneUI launcher and gives instructions to apply third-party icon packs with the help of the free app "Theme Park". Samsung's OneUI launcher version is tightly coupled to the Android OS version. Starting OneUI 3.1.1, icon theming is supported on Android 11, foldable devices only[1] Starting OneUI 4.0, icon theming is supported on all Android 12 devices[2] Sadly it's impossible to detect the OneUI version programmatically[3]. Technically it's incorrect to report all Android 11 devices as incompatible but the only other option is to try and list out all device models individually. This commit adds the display of a "please update to Android 12" message to anyone running Android 11 or lower, and display step-by-step theming instructions to everyone else. [1] https://www.androidpolice.com/how-to-use-custom-icon-packs-on-samsung-one-ui-4/ [2] https://en.wikipedia.org/wiki/One_UI#One_UI_4_2 [3] zixpo#122 (comment)
FYI, I wanted to report back that this has now been published in my own icon packs for little over a week and it's working great. No complaints, and quite a few comments from happy Samsung users. |
This PR adds functionality to detect Samsung OneUI launcher and gives instructions
to apply third-party icon packs.
Samsung's OneUI launcher version is tightly coupled to the Android OS version.
Starting OneUI 3.1.1, icon theming is supported on Android 11, foldable devices only[1]
Starting OneUI 4.0, icon theming is supported on all Android 12 devices[2]
Sadly it's impossible to detect the OneUI version programmatically[3].
Technically it's incorrect to report all Android 11 devices as incompatible but the
only other option is to try and list out all device models individually. This commit
adds the display of a "please update to Android 12" message to anyone running Android
11 or lower, and displays step-by-step theming instructions to everyone else.
[1] https://www.androidpolice.com/how-to-use-custom-icon-packs-on-samsung-one-ui-4/
[2] https://en.wikipedia.org/wiki/One_UI#One_UI_4_2
[3] #122 (comment)
Behaviour & UI
Verified
The behaviour described above has been tested on the devices and Android versions below: