lsp: parse URIs properly to allow spaces in paths #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cormacrelf
changed the title
mickael-menu
approved these changes
May 5, 2021
There was a problem hiding this comment.
Thanks, using the url package is indeed much better!
Would you mind checking the "allow edits from maintainers" if you open another PR in the future? I'm updating the changelog in the original PR usually. This gives me write access only to the PR branch, not your whole fork.
|
It seems to be checked by default? I didn't do it deliberately for either but my other PR has it enabled! |
|
Yes I think it is enabled by default, weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For paths like
/path to my/zettelkasten. Uses theurlpackage from Go.