Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some variants for copy/reflink/hard-link are missed #80

Closed
ShuiRuTian opened this issue Jun 13, 2024 · 0 comments · Fixed by #82
Closed

Some variants for copy/reflink/hard-link are missed #80

ShuiRuTian opened this issue Jun 13, 2024 · 0 comments · Fixed by #82

Comments

@ShuiRuTian
Copy link
Contributor

ShuiRuTian commented Jun 13, 2024 •
edited
Loading

For copy/reflink/hard-link, there should be

  • xx
  • xx_unchecked
  • xx_hash
  • xx_hash_unchecked

And their sync variant version. So there shuold be 8 methods for each category.

However, some methods are missed:

  • reflink_hash_unchecked
  • hard_link_hash
  • hard_link_unchecked
  • hard_link_hash_unchecked

Seems reflink_hash_unchecked hard_link_hash_unchecked and hard_link_unchecked are not very useful.

hard_link_hash is missed anyway.
@ShuiRuTian ShuiRuTian mentioned this issue Jun 13, 2024
Merged
zkat pushed a commit that referenced this issue Jun 14, 2024
@ShuiRuTian
feat(link): add hard_link_hash (#82)
ab5f1c9 
Fixes: #80
@zkat zkat closed this as completed in #82 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add hard_link_hash ShuiRuTian/cacache-rs
1 participant
@ShuiRuTian