Add support for primary label in specifying line/col information #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #91 and #208, it is sometimes desirable for the line/column numbers in a diagnostic to reference a label as opposed to the start of the context. However, there has to be a way of identifying which label to reference.
This PR implements one possible mechanism: a
label(primary)
attribute which acts just likelabel
, except it marks a single label as being "primary". For example, this program:Produces this output:
Note that the line/column info is
2:2
rather than1:1
which you would get with a normal#[label]
.The core technical changes are:
primary: bool
field toLabeledSpan
.LabeledSpan::new_primary_with_span
that constructs aLabeledSpan
withprimary: true
.label(primary)
.GraphicalHandler
to look for a primary label and use it if possible.graphical.rs
to check for this behavior.These changes were specifically made to be fully backwards compatible.
This is my first time in the miette codebase, so I may have missed a code path. Let me know if I should change anything.