Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevating u128-support to default #80

Open
ebfull opened this issue Mar 29, 2018 · 3 comments
Open

Elevating u128-support to default #80

ebfull opened this issue Mar 29, 2018 · 3 comments
Milestone

Comments

@ebfull
Copy link
Collaborator

ebfull commented Mar 29, 2018

I'd like to use u128 only in this library and remove the backup arithmetic, but only if its arithmetic is lowered properly on target platforms that don't support it.

My ideal strategy:

  1. Remove feature(i128_type) invocation, since it is no longer needed on nightly or (eventually) the 1.26 beta compiler. Do patch release.
  2. Once 1.26 stable is released, change documentation to remove mentions of nightly. CI can be changed to always target stable, except for clippy. (See Change CI to compile on latest nightly #45)
  3. When u128 lowering definitely works, remove backup arithmetic and use u128-support arithmetic only. The u128-support feature will do nothing. In the next minor release, remove the u128-support feature.
@scottmcm
Copy link

The lowering is definitely incomplete today. Last I was working on it it could lower the operators, but a bunch of platforms didn't have support for passing and returning i128, so that was insufficient. And there's still additional work needed to lower things like i128::checked_add.

@Mark-Simulacrum
Copy link

Please don't remove nightly/beta from CI. It'll help make sure we don't regress anything you depend on without knowing it.

@ebfull
Copy link
Collaborator Author

ebfull commented Mar 30, 2018

Okay. BTW My CI only tests against nightly when we merge PR's, which isn't that often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants