Add templates it includes slippage param for uniswap.

[wshino]

• Implement templates including slippage param
• Add mocking unit testing

[saleel]

I think a good way to test would be depositing exactly 0.2 WETH to the wallet, and then assert WETH value went to 0 and DAI value increased to 0.2*PRICE. Can we mock the uniswap methods return a fake price for WETH/DAI and check actual balances at the end of the test?

[wshino]

Thanks @saleel for you review🙏
I thought it would be nice to be able to do that as well. However, this is a process in ISwapRouter.interactInputSingle, so I could only mockCall it this time. Of course, integration testing can be used to fork the actual uniswap and see the value change.
If I find a better way, I will update the test.

[wshino]

@saleel Or maybe we can use fork testing feature same as integration testing, but it might cause some slowdown.
@SoraSuegami What is your opinion?

[saleel]

I see ok, I think we can leave it like this in unit tests then and do proper checks in integration tests. I think its better not to make unit tests slow/complex.
Maybe you want to add one integration test with slippage/sqrt?

[SoraSuegami]

I think its better not to make unit tests slow/complex.

I agree with that point.
Please let me know if you need a new email from my email address for the new integration test.

[wshino]

@saleel @SoraSuegami Thank you for your reply,

@saleel Yes I'd like to implement a few integration testing with slippage/sqrt as you said.

@SoraSuegami Could you please new emails like below:

Swap 0.2 ETH to DAI with 0.5 slippage
Swap 200 DAI to USDC under 79244154773652573370267 sqrt price limit

[saleel]

We can call this defaultSlippage? or defaultSlippagePoints

[wshino]

@saleel I think it's easier to understand. Let me update then.

[SoraSuegami]

@wshino
Thank you for your updates!
Could you split the word of "sqrt price limit" in the subject templates into separated values in the array, i.e., defining [..., "sqrt", "price", "limit"] instead of [..., "sqrt price limit"]?
It is not a critical issue but the template words should be split by space.

[SoraSuegami]

Thank you!
Please add your commits to the audit-fix branch as well.