fix(contract): fix waitForDeployment missing startBlock

zksync-sdk · Nov 1, 2024 · 8ce644f · 8ce644f
1 parent fa17f54
commit 8ce644f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/contract.ts b/src/contract.ts
@@ -241,12 +241,12 @@ export class ContractFactory<
 
     const deploymentTx = contract.deploymentTransaction()!;
 
-    contractWithCorrectAddress.deploymentTransaction = () =>
-      Object.assign(
-        Object.create(Object.getPrototypeOf(deploymentTx)),
-        deploymentTx,
-        deployTxReceipt
-      ) as ContractTransactionResponse;
+    (deploymentTx as any).blockNumber = deployTxReceipt.blockNumber;
+    (deploymentTx as any).blockHash = deployTxReceipt.blockHash;
+    (deploymentTx as any).index = deployTxReceipt.index;
+    (deploymentTx as any).gasPrice = deployTxReceipt.gasPrice;
+
+    contractWithCorrectAddress.deploymentTransaction = () => deploymentTx;
     return contractWithCorrectAddress;
   }
 }

diff --git a/tests/integration/contract.test.ts b/tests/integration/contract.test.ts
@@ -65,6 +65,7 @@ describe('ContractFactory', () => {
       const bytecode: string = Storage.contracts['Storage.sol:Storage'].bin;
       const factory = new ContractFactory(abi, bytecode, wallet);
       const contract = await factory.deploy();
+      await contract.waitForDeployment();
 
       const code = await provider.getCode(await contract.getAddress());
       expect(code).not.to.be.null;
@@ -119,6 +120,7 @@ describe('ContractFactory', () => {
       const contract = await factory.deploy({
         customData: {salt: ethers.hexlify(ethers.randomBytes(32))},
       });
+      await contract.waitForDeployment();
 
       const code = await provider.getCode(await contract.getAddress());
       expect(code).not.to.be.null;