Update back_box_numeric.py #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
zlatko-minev
reviewed
Nov 7, 2024
| @@ -267,7 +267,7 @@ def PT_on_vector(original_vector, original_basis, pertub, energy0, evalue): | |||
|
|
|||
| def closest_state_to(s): | |||
| def distance(s2): | |||
| return (s.dag() * s2[1]).norm() | |||
| return np.abs((s.dag() * s2[1])) | |||
There was a problem hiding this comment.
Great!
Have you checked if this works with the new version?
And ideally if it is backwards compatible
There is also this possibility I think if not mistaken
return np.abs(np.vdot(s, s2[1]))
There was a problem hiding this comment.
Just tested it with a fresh install with python3.10 and latest numpy. Ran into no problems. Numpy was a red herring: it turns out that that was not the problem after all. I don't know exactly was, but the pull request fixes it.
There was a problem hiding this comment.
Thank you Garry! Going to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also issue 162:
#162