enable some rules from eslint-plugin-n(ode)

zloirock · Sep 7, 2023 · 44f3ce9 · 44f3ce9
1 parent 06ce4ba
commit 44f3ce9
Show file tree

Hide file tree

Showing 473 changed files with 578 additions and 563 deletions.
diff --git a/packages/core-js/postinstall.js b/packages/core-js/postinstall.js
@@ -1,4 +1,5 @@
 'use strict';
+/* eslint-disable node/no-sync -- avoiding overcomplicating */
 var fs = require('fs');
 var os = require('os');
 var path = require('path');

diff --git a/tests/eslint/eslint.config.js b/tests/eslint/eslint.config.js
@@ -454,12 +454,16 @@ const base = {
   'import/no-useless-path-segments': ERROR,
 
   // node:
-  // disallow deprecated APIs
-  'node/no-deprecated-api': ERROR,
+  // enforce the style of file extensions in `import` declarations
+  'node/file-extension-in-import': ERROR,
   // require require() calls to be placed at top-level module scope
   'node/global-require': ERROR,
+  // disallow deprecated APIs
+  'node/no-deprecated-api': ERROR,
   // disallow the assignment to `exports`
   'node/no-exports-assign': ERROR,
+  // disallow third-party modules which are hiding core modules
+  'node/no-hide-core-modules': ERROR,
   // disallow require calls to be mixed with regular variable declarations
   'node/no-mixed-requires': [ERROR, { grouping: true, allowCall: false }],
   // disallow new operators with calls to require
@@ -468,6 +472,8 @@ const base = {
   'node/no-path-concat': ERROR,
   // disallow the use of `process.exit()`
   'node/no-process-exit': ERROR,
+  // disallow synchronous methods
+  'node/no-sync': ERROR,
   // prefer global
   'node/prefer-global/buffer': [ERROR, ALWAYS],
   'node/prefer-global/console': [ERROR, ALWAYS],
@@ -476,6 +482,9 @@ const base = {
   'node/prefer-global/text-encoder': [ERROR, ALWAYS],
   'node/prefer-global/url-search-params': [ERROR, ALWAYS],
   'node/prefer-global/url': [ERROR, ALWAYS],
+  // prefer promises
+  'node/prefer-promises/dns': ERROR,
+  'node/prefer-promises/fs': ERROR,
 
   // array-func:
   // avoid reversing the array and running a method on it if there is an equivalent of the method operating on the array from the other end
@@ -1117,8 +1126,13 @@ const nodePackages = {
   'array-func/prefer-flat': OFF,
   // enforces the use of `catch()` on un-returned promises
   'promise/catch-or-return': ERROR,
+  // disallow third-party modules which are hiding core modules
+  'node/no-hide-core-modules': OFF,
   // disallow unsupported ECMAScript built-ins on the specified version
   'node/no-unsupported-features/node-builtins': [ERROR, { version: PACKAGES_NODE_VERSIONS }],
+  // prefer promises
+  'node/prefer-promises/dns': OFF,
+  'node/prefer-promises/fs': OFF,
   ...disable(forbidES5BuiltIns),
   ...disable(forbidES2015BuiltIns),
   ...disable(forbidES2016BuiltIns),

diff --git a/tests/helpers/qunit-helpers.js b/tests/helpers/qunit-helpers.js
@@ -1,9 +1,9 @@
-import { DESCRIPTORS } from './constants';
+import { DESCRIPTORS } from './constants.js';
 import assign from 'core-js-pure/es/object/assign';
 import defineProperties from 'core-js-pure/es/object/define-properties';
 import isIterable from 'core-js-pure/es/is-iterable';
 import ASYNC_ITERATOR from 'core-js-pure/es/symbol/async-iterator';
-import { is, arrayFromArrayLike } from './helpers';
+import { is, arrayFromArrayLike } from './helpers.js';
 
 // for Babel template transform
 if (!Object.freeze) Object.freeze = Object;

diff --git a/tests/unit-global/es.array-buffer.constructor.js b/tests/unit-global/es.array-buffer.constructor.js
@@ -1,4 +1,4 @@
-import { DESCRIPTORS, GLOBAL, NATIVE } from '../helpers/constants';
+import { DESCRIPTORS, GLOBAL, NATIVE } from '../helpers/constants.js';
 
 QUnit.test('ArrayBuffer', assert => {
   const Symbol = GLOBAL.Symbol || {};

diff --git a/tests/unit-global/es.array-buffer.is-view.js b/tests/unit-global/es.array-buffer.is-view.js
@@ -1,4 +1,4 @@
-import { TYPED_ARRAYS } from '../helpers/constants';
+import { TYPED_ARRAYS } from '../helpers/constants.js';
 
 QUnit.test('ArrayBuffer.isView', assert => {
   const { isView } = ArrayBuffer;

diff --git a/tests/unit-global/es.array-buffer.slice.js b/tests/unit-global/es.array-buffer.slice.js
@@ -1,4 +1,4 @@
-import { arrayToBuffer, bufferToArray } from '../helpers/helpers';
+import { arrayToBuffer, bufferToArray } from '../helpers/helpers.js';
 
 QUnit.test('ArrayBuffer#slice', assert => {
   const { slice } = ArrayBuffer.prototype;

diff --git a/tests/unit-global/es.array.at.js b/tests/unit-global/es.array.at.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#at', assert => {
   const { at } = Array.prototype;

diff --git a/tests/unit-global/es.array.copy-within.js b/tests/unit-global/es.array.copy-within.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#copyWithin', assert => {
   const { copyWithin } = Array.prototype;

diff --git a/tests/unit-global/es.array.every.js b/tests/unit-global/es.array.every.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#every', assert => {
   const { every } = Array.prototype;

diff --git a/tests/unit-global/es.array.fill.js b/tests/unit-global/es.array.fill.js
@@ -1,4 +1,4 @@
-import { DESCRIPTORS, NATIVE, STRICT } from '../helpers/constants';
+import { DESCRIPTORS, NATIVE, STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#fill', assert => {
   const { fill } = Array.prototype;

diff --git a/tests/unit-global/es.array.filter.js b/tests/unit-global/es.array.filter.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#filter', assert => {
   const { filter } = Array.prototype;

diff --git a/tests/unit-global/es.array.find-index.js b/tests/unit-global/es.array.find-index.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#findIndex', assert => {
   const { findIndex } = Array.prototype;

diff --git a/tests/unit-global/es.array.find-last-index.js b/tests/unit-global/es.array.find-last-index.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#findLastIndex', assert => {
   const { findLastIndex } = Array.prototype;

diff --git a/tests/unit-global/es.array.find-last.js b/tests/unit-global/es.array.find-last.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#findLast', assert => {
   const { findLast } = Array.prototype;

diff --git a/tests/unit-global/es.array.find.js b/tests/unit-global/es.array.find.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#find', assert => {
   const { find } = Array.prototype;

diff --git a/tests/unit-global/es.array.flat-map.js b/tests/unit-global/es.array.flat-map.js
@@ -1,5 +1,5 @@
 /* eslint-disable unicorn/prefer-array-flat -- required for testing */
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#flatMap', assert => {
   const { flatMap } = Array.prototype;

diff --git a/tests/unit-global/es.array.flat.js b/tests/unit-global/es.array.flat.js
@@ -1,4 +1,4 @@
-import { DESCRIPTORS, STRICT } from '../helpers/constants';
+import { DESCRIPTORS, STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#flat', assert => {
   const { flat } = Array.prototype;

diff --git a/tests/unit-global/es.array.for-each.js b/tests/unit-global/es.array.for-each.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#forEach', assert => {
   const { forEach } = Array.prototype;

diff --git a/tests/unit-global/es.array.from.js b/tests/unit-global/es.array.from.js
@@ -1,6 +1,6 @@
 /* eslint-disable prefer-rest-params -- required for testing */
-import { DESCRIPTORS, GLOBAL } from '../helpers/constants';
-import { createIterable } from '../helpers/helpers';
+import { DESCRIPTORS, GLOBAL } from '../helpers/constants.js';
+import { createIterable } from '../helpers/helpers.js';
 
 QUnit.test('Array.from', assert => {
   const Symbol = GLOBAL.Symbol || {};

diff --git a/tests/unit-global/es.array.includes.js b/tests/unit-global/es.array.includes.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#includes', assert => {
   const { includes } = Array.prototype;

diff --git a/tests/unit-global/es.array.index-of.js b/tests/unit-global/es.array.index-of.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#indexOf', assert => {
   const { indexOf } = Array.prototype;

diff --git a/tests/unit-global/es.array.iterator.js b/tests/unit-global/es.array.iterator.js
@@ -1,4 +1,4 @@
-import { GLOBAL } from '../helpers/constants';
+import { GLOBAL } from '../helpers/constants.js';
 
 const Symbol = GLOBAL.Symbol || {};
 

diff --git a/tests/unit-global/es.array.join.js b/tests/unit-global/es.array.join.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#join', assert => {
   const { join } = Array.prototype;

diff --git a/tests/unit-global/es.array.last-index-of.js b/tests/unit-global/es.array.last-index-of.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#lastIndexOf', assert => {
   const { lastIndexOf } = Array.prototype;

diff --git a/tests/unit-global/es.array.map.js b/tests/unit-global/es.array.map.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#map', assert => {
   const { map } = Array.prototype;

diff --git a/tests/unit-global/es.array.of.js b/tests/unit-global/es.array.of.js
@@ -1,4 +1,4 @@
-import { DESCRIPTORS } from '../helpers/constants';
+import { DESCRIPTORS } from '../helpers/constants.js';
 
 QUnit.test('Array.of', assert => {
   const { defineProperty } = Object;

diff --git a/tests/unit-global/es.array.push.js b/tests/unit-global/es.array.push.js
@@ -1,4 +1,4 @@
-import { REDEFINABLE_ARRAY_LENGTH_DESCRIPTOR, STRICT } from '../helpers/constants';
+import { REDEFINABLE_ARRAY_LENGTH_DESCRIPTOR, STRICT } from '../helpers/constants.js';
 
 const { defineProperty } = Object;
 

diff --git a/tests/unit-global/es.array.reduce-right.js b/tests/unit-global/es.array.reduce-right.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#reduceRight', assert => {
   const { reduceRight } = Array.prototype;

diff --git a/tests/unit-global/es.array.reduce.js b/tests/unit-global/es.array.reduce.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#reduce', assert => {
   const { reduce } = Array.prototype;

diff --git a/tests/unit-global/es.array.reverse.js b/tests/unit-global/es.array.reverse.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#reverse', assert => {
   const { reverse } = Array.prototype;

diff --git a/tests/unit-global/es.array.slice.js b/tests/unit-global/es.array.slice.js
@@ -1,4 +1,4 @@
-import { GLOBAL, STRICT } from '../helpers/constants';
+import { GLOBAL, STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#slice', assert => {
   const { slice } = Array.prototype;

diff --git a/tests/unit-global/es.array.some.js b/tests/unit-global/es.array.some.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#some', assert => {
   const { some } = Array.prototype;

diff --git a/tests/unit-global/es.array.sort.js b/tests/unit-global/es.array.sort.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#sort', assert => {
   const { sort } = Array.prototype;

diff --git a/tests/unit-global/es.array.splice.js b/tests/unit-global/es.array.splice.js
@@ -1,4 +1,4 @@
-import { REDEFINABLE_ARRAY_LENGTH_DESCRIPTOR, STRICT } from '../helpers/constants';
+import { REDEFINABLE_ARRAY_LENGTH_DESCRIPTOR, STRICT } from '../helpers/constants.js';
 
 const { defineProperty } = Object;
 

diff --git a/tests/unit-global/es.array.to-reversed.js b/tests/unit-global/es.array.to-reversed.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#toReversed', assert => {
   const { toReversed } = Array.prototype;

diff --git a/tests/unit-global/es.array.to-sorted.js b/tests/unit-global/es.array.to-sorted.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#toSorted', assert => {
   const { toSorted } = Array.prototype;

diff --git a/tests/unit-global/es.array.to-spliced.js b/tests/unit-global/es.array.to-spliced.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#toSpliced', assert => {
   const { toSpliced } = Array.prototype;

diff --git a/tests/unit-global/es.array.unshift.js b/tests/unit-global/es.array.unshift.js
@@ -1,4 +1,4 @@
-import { REDEFINABLE_ARRAY_LENGTH_DESCRIPTOR, STRICT } from '../helpers/constants';
+import { REDEFINABLE_ARRAY_LENGTH_DESCRIPTOR, STRICT } from '../helpers/constants.js';
 
 const { defineProperty } = Object;
 

diff --git a/tests/unit-global/es.array.with.js b/tests/unit-global/es.array.with.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Array#with', assert => {
   const { with: withAt } = Array.prototype;

diff --git a/tests/unit-global/es.data-view.js b/tests/unit-global/es.data-view.js
@@ -1,4 +1,4 @@
-import { DESCRIPTORS, NATIVE } from '../helpers/constants';
+import { DESCRIPTORS, NATIVE } from '../helpers/constants.js';
 
 QUnit.test('DataView', assert => {
   assert.same(DataView, Object(DataView), 'is object'); // in Safari 5 typeof DataView is 'object'

diff --git a/tests/unit-global/es.date.to-primitive.js b/tests/unit-global/es.date.to-primitive.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Date#@@toPrimitive', assert => {
   const toPrimitive = Date.prototype[Symbol.toPrimitive];

diff --git a/tests/unit-global/es.error.cause.js b/tests/unit-global/es.error.cause.js
@@ -1,4 +1,4 @@
-import { GLOBAL, PROTO } from '../helpers/constants';
+import { GLOBAL, PROTO } from '../helpers/constants.js';
 
 const { create } = Object;
 

diff --git a/tests/unit-global/es.error.to-string.js b/tests/unit-global/es.error.to-string.js
@@ -1,4 +1,4 @@
-import { STRICT } from '../helpers/constants';
+import { STRICT } from '../helpers/constants.js';
 
 QUnit.test('Error#toString', assert => {
   const { toString } = Error.prototype;

diff --git a/tests/unit-global/es.function.name.js b/tests/unit-global/es.function.name.js
@@ -1,4 +1,4 @@
-import { DESCRIPTORS } from '../helpers/constants';
+import { DESCRIPTORS } from '../helpers/constants.js';
 
 if (DESCRIPTORS) {
   QUnit.test('Function#name', assert => {

diff --git a/tests/unit-global/es.json.stringify.js b/tests/unit-global/es.json.stringify.js
@@ -1,7 +1,7 @@
 // Some tests adopted from Test262 project and governed by the BSD license.
 // Copyright (c) 2012 Ecma International. All rights reserved.
 /* eslint-disable es/no-bigint,unicorn/no-hex-escape -- testing */
-import { DESCRIPTORS, GLOBAL } from '../helpers/constants';
+import { DESCRIPTORS, GLOBAL } from '../helpers/constants.js';
 
 if (GLOBAL.JSON?.stringify) {
   QUnit.test('JSON.stringify', assert => {

diff --git a/tests/unit-global/es.map.js b/tests/unit-global/es.map.js
@@ -1,7 +1,7 @@
 /* eslint-disable sonarjs/no-element-overwrite -- required for testing */
 
-import { DESCRIPTORS, GLOBAL, NATIVE } from '../helpers/constants';
-import { createIterable, is, nativeSubclass } from '../helpers/helpers';
+import { DESCRIPTORS, GLOBAL, NATIVE } from '../helpers/constants.js';
+import { createIterable, is, nativeSubclass } from '../helpers/helpers.js';
 
 const Symbol = GLOBAL.Symbol || {};
 const { getOwnPropertyDescriptor, keys, getOwnPropertyNames, getOwnPropertySymbols, freeze } = Object;

diff --git a/tests/unit-global/es.math.acosh.js b/tests/unit-global/es.math.acosh.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 QUnit.test('Math.acosh', assert => {
   const { acosh } = Math;

diff --git a/tests/unit-global/es.math.asinh.js b/tests/unit-global/es.math.asinh.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 QUnit.test('Math.asinh', assert => {
   const { asinh } = Math;

diff --git a/tests/unit-global/es.math.atanh.js b/tests/unit-global/es.math.atanh.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 QUnit.test('Math.atanh', assert => {
   const { atanh } = Math;

diff --git a/tests/unit-global/es.math.cbrt.js b/tests/unit-global/es.math.cbrt.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 QUnit.test('Math.cbrt', assert => {
   const { cbrt } = Math;

diff --git a/tests/unit-global/es.math.clz32.js b/tests/unit-global/es.math.clz32.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 QUnit.test('Math.clz32', assert => {
   const { clz32 } = Math;

diff --git a/tests/unit-global/es.math.cosh.js b/tests/unit-global/es.math.cosh.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 QUnit.test('Math.cosh', assert => {
   const { cosh } = Math;

diff --git a/tests/unit-global/es.math.expm1.js b/tests/unit-global/es.math.expm1.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 QUnit.test('Math.expm1', assert => {
   const { expm1 } = Math;

diff --git a/tests/unit-global/es.math.fround.js b/tests/unit-global/es.math.fround.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 const { MAX_VALUE, MIN_VALUE } = Number;
 

diff --git a/tests/unit-global/es.math.hypot.js b/tests/unit-global/es.math.hypot.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 QUnit.test('Math.hypot', assert => {
   const { hypot, sqrt } = Math;

diff --git a/tests/unit-global/es.math.imul.js b/tests/unit-global/es.math.imul.js
@@ -1,4 +1,4 @@
-import { createConversionChecker } from '../helpers/helpers';
+import { createConversionChecker } from '../helpers/helpers.js';
 
 QUnit.test('Math.imul', assert => {
   const { imul } = Math;