Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript definitions for core-js-builder #1163

Merged
merged 4 commits into from
Jan 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
"compat-hermes": "zx tests/compat/hermes-adapter.mjs",
"compat-node": "node tests/compat/node-runner",
"compat-rhino": "zx tests/compat/rhino-adapter.mjs --version=1.7.14",
"lint": "run-s init test-eslint bundle test-publint",
"test": "run-s init test-eslint bundle test-publint test-unit test-promises test-observables test-entries test-compat-data test-compat-tools test-builder check",
"lint": "run-s init test-eslint test-type-definitions bundle test-publint",
"test": "run-s lint test-unit test-promises test-observables test-entries test-compat-data test-compat-tools test-builder check",
"test-eslint": "npm run zxi tests/eslint/runner.mjs",
"test-publint": "npm run zxi tests/publint/runner.mjs",
"test-unit": "run-s test-unit-karma test-unit-node",
Expand All @@ -44,6 +44,7 @@
"test-builder": "zx tests/builder/builder.mjs",
"test-compat-data": "zx tests/compat-data/index.mjs",
"test-compat-tools": "zx tests/compat-tools/index.mjs",
"test-type-definitions": "npm run zxi cd tests/type-definitions/runner.mjs",
"test262": "npm run zxi cd tests/test262/runner.mjs",
"refresh": "node scripts/clean-dependencies.mjs && npm install-test",
"downloads": "zx scripts/downloads-by-versions.mjs",
Expand Down
2 changes: 2 additions & 0 deletions packages/core-js-builder/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,5 @@ const bundle = await builder({
filename: PATH_TO_MY_COREJS_BUNDLE,
});
```

ℹ️ When using TypeScript, make sure to set `esModuleInterop` to `true`.
71 changes: 71 additions & 0 deletions packages/core-js-builder/index.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
type StringOrRegExp = string | RegExp;

type Modules = StringOrRegExp | readonly StringOrRegExp[];

type Target =
| 'android'
| 'bun'
| 'chrome'
| 'chrome-android'
| 'deno'
| 'edge'
| 'electron'
| 'firefox'
| 'firefox-android'
| 'hermes'
| 'ie'
| 'ios'
| 'node'
| 'opera'
| 'opera-android'
| 'phantom'
| 'quest'
| 'react-native'
| 'rhino'
| 'safari'
| 'samsung';

type BrowserslistQuery = string | ReadonlyArray<string>;

type Environments = {
[target in Target]?: string | number;
};

type Targets = Environments & {
browsers?: Environments | BrowserslistQuery,
esmodules?: boolean,
};

type Format = 'bundle' | 'esm' | 'cjs';

type SummaryEntry = boolean | {
size?: boolean,
modules?: boolean,
};

type Summary = {
/** in the console, you could specify required parts or set `true` for enable all of them */
comment?: SummaryEntry,
/** in the comment, you could specify required parts or set `true` for enable all of them */
console?: SummaryEntry,
};

type Options = {
/** entry / module / namespace / an array of them, by default - all `core-js` modules */
modules?: Modules,
/** a blacklist, entry / module / namespace / an array of them, by default - empty list */
exclude?: Modules,
/** optional browserslist or core-js-compat format query */
targets?: Targets | BrowserslistQuery,
/** output format, 'bundle' by default, can be 'cjs' or 'esm', and in this case
* the result will not be bundled and will contain imports of required modules */
format?: Format,
/** optional target filename, if it's missed a file will not be created */
filename?: string,
/** shows summary for the bundle, disabled by default */
summary?: Summary,
};

declare function builder(options?: Options): Promise<string>;

export = builder;
1 change: 1 addition & 0 deletions packages/core-js-builder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
},
"sideEffects": false,
"main": "index.js",
"types": "index.d.ts",
"dependencies": {
"core-js": "3.27.2",
"core-js-compat": "3.27.2",
Expand Down
68 changes: 68 additions & 0 deletions tests/type-definitions/builder.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
import builder from 'core-js-builder';

const a: Promise<string> = builder({ targets: { node: 17 } });
const b: string = await builder({ targets: { node: 17 } });

await builder();
await builder({});
await builder({ modules: 'core-js/actual' });
await builder({ modules: 'es.array.push' });
await builder({ modules: /^es\.array\./ });
await builder({ modules: ['core-js/actual', /^es\.array\./] });
await builder({ exclude: 'core-js/actual' });
await builder({ exclude: 'es.array.push' });
await builder({ exclude: /^es\.array\./ });
await builder({ exclude: ['core-js/actual', /^es\.array\./] });
await builder({ modules: 'core-js/actual', exclude: /^es\.array\./ });
await builder({ targets: '> 1%' });
await builder({ targets: ['defaults', 'last 5 versions'] });
await builder({ targets: { esmodules: true, node: 'current', browsers: ['> 1%'] } });
await builder({ targets: { chrome: '26', firefox: 4 } });
await builder({ targets: { browsers: { chrome: '26', firefox: 4 } } });
await builder({ targets: { chrome: '26', firefox: 4, esmodules: true, node: 'current', browsers: ['> 1%'] } });
await builder({ format: 'bundle' });
await builder({ format: 'esm' });
await builder({ format: 'cjs' });
await builder({ filename: '/foo/bar/baz.js' });
await builder({ summary: { comment: true } });
await builder({ summary: { comment: { size: true } } });
await builder({ summary: { comment: { size: false, modules: true } } });
await builder({ summary: { console: true } });
await builder({ summary: { console: { size: true } } });
await builder({ summary: { console: { size: false, modules: true } } });
await builder({ summary: { console: { size: false, modules: true }, comment: { size: false, modules: true } } });
await builder({
modules: 'core-js/actual',
exclude: /^es\.array\./,
targets: {
android: 1,
bun: '1',
chrome: 1,
'chrome-android': '1',
deno: 1,
edge: '1',
electron: 1,
firefox: '1',
'firefox-android': 1,
hermes: '1',
ie: 1,
ios: '1',
opera: 1,
'opera-android': '1',
phantom: 1,
quest: '1',
'react-native': 1,
rhino: '1',
safari: 1,
samsung: '1',
node: 'current',
esmodules: true,
browsers: ['> 1%'],
},
format: 'bundle',
filename: '/foo/bar/baz.js',
summary: {
console: { size: false, modules: true },
comment: { size: false, modules: true },
},
});
26 changes: 26 additions & 0 deletions tests/type-definitions/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions tests/type-definitions/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "tests/type-definitions",
"devDependencies": {
"typescript": "^4.9.4"
}
}
1 change: 1 addition & 0 deletions tests/type-definitions/runner.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
await $`tsc`;
13 changes: 13 additions & 0 deletions tests/type-definitions/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"compilerOptions": {
"strict": true,
"target": "esnext",
"module": "esnext",
"moduleResolution": "node",
"esModuleInterop": true,
"noEmit": true
},
"include": [
"*.ts"
]
}