Safari's impl of padStart/end is buggy. Force use of poly till fix released #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forced replacement of built-ins without testing is not a solution. If you can add a simple detection of broken feature, it should solve the problem. |
|
This bug isnt really detectable unless we are going to get into browser version sniffing. Im going to go ahead and close this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in current safari that causes padStart/End to return null. https://bugs.webkit.org/show_bug.cgi?id=161944 its resolved in preview 15. I propose marking the core-js poly as forced until implementation stabilizes. Also the build changed a bunch of files. I am not sure if I am supposed to include those. First commit is what I changed second is what the build system changed.
PR for #280