Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken getOwnPropertySymbols in Mobile Chrome 38 and 39 #539

Merged
merged 3 commits into from
May 10, 2019

Conversation

nicketson
Copy link
Contributor

This is a workaround for this chrome issue
https://bugs.chromium.org/p/v8/issues/detail?id=3443

Without this fix, the object spread operator is broken for these
versions of chrome when transpiling and shimming with babel and
core-js@3.
See babel/babel#8721

This is a workaround for this chrome issue
https://bugs.chromium.org/p/v8/issues/detail?id=3443

Without this fix, the object spread operator is broken for these
versions of chrome when transpiling and shimming with babel and
core-js@3.
See babel/babel#8721
@zloirock
Copy link
Owner

Could you also update tests/tests/es.symbol.js, tests/pure/es.symbol.js, tests/compat/tests.js?

@nicketson
Copy link
Contributor Author

Does this look good now? Do you want me to rebase it?

@zloirock
Copy link
Owner

zloirock commented May 8, 2019

Yep, LGTM. Only one (mainly stylistic) moment - I'd prefer to have only one export of getOwnPropertySymbols in es.symbol. It's not critical and I can change it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants