Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http module panic #327

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Fix http module panic #327

merged 1 commit into from
Oct 12, 2021

Conversation

vl4deee11
Copy link
Contributor

@vl4deee11 vl4deee11 commented Sep 30, 2021 •
edited
Loading

Fix possible http module panic
it can happend when io.CopyN retrun error and readLen != len(bodyText)
https://pkg.go.dev/io#CopyN

How to Test

Test based on http requests

Issue Tracking

#319

@vl4deee11
Copy link
Contributor Author

vl4deee11 commented Oct 1, 2021 •
edited
Loading

@mzpqnxow @dadrian check this PR please

@dadrian dadrian merged commit c9a9ac1 into zmap:master Oct 12, 2021
@dadrian
Copy link
Member

dadrian commented Oct 12, 2021

Sorry for the delay!

@vl4deee11
Copy link
Contributor Author

@dadrian thanks! =)

codyprime added a commit that referenced this pull request Dec 17, 2021
@codyprime
tls 1.3: zcrypto feature branch, SupportedVersions ext
e1119e8 
This commit updates to the latest zcrypto feature branch, which pulls
in:

 commit d08a277a83a73c294fe5210117e328c67d6e55ba
 Author: Jeff Cody <jcody@censys.io>
 Date:   Fri Dec 17 16:32:10 2021 -0500

    tls 1.3: Add support for SupportedVersions Extension in log (#327)
    For TLS 1.3 connections, SupportedVersions.SelectedVersions will be
    present, and be 0x0304.  Add this to the HandshakeLog, if present.
constantinsander pushed a commit to COMSYS/quic-zgrab2 that referenced this pull request Sep 11, 2023
@vl4deee11 @constantinsander
Fix possible http module panic
88e153f 
zmap/zgrab2#327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadrian dadrian dadrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vl4deee11 @dadrian