Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UzK: Navigation links in ZMI with the configured subdomain instead absolute_url #23 #24

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

zmsdev
Copy link
Contributor

@zmsdev zmsdev commented Nov 11, 2021

New method ZMSObject.getAbsoluteUrlInContext(self, context, index_html=None) defaulting to absolute_url()
Usage of subdomain can be activated with the conf-property ZMSObject.getAbsoluteUrlInContext=True

@zmsdev zmsdev added the enhancement New feature or request label Nov 11, 2021
@zmsdev zmsdev requested review from cmeier76 and drfho November 11, 2021 19:59
@zmsdev zmsdev self-assigned this Nov 11, 2021
@drfho
Copy link
Contributor

drfho commented Nov 11, 2021

hi @zmsdev,
i am not sure about the intention of the function; actually the name does not name it very precisely. The term "context" may be ambiguous . So, a brief explanation as a code comment would be really great:

  1. what does the function do
  2. when should it be used
  3. how is it activated
  4. are there any caveats?

@zmsdev
Copy link
Contributor Author

zmsdev commented Nov 11, 2021

added python-documentation:
7362ed2

@cmeier76
Copy link
Member

LGTM

The new feature toggle allows us at UniBE to keep on track with the main code base - but leave the toggle off in our environment and continue to use absolute_url(), as we rely on a dedicated subdomain for all ZMI access with the needed read-write rights to ZODB.

Just the rendering of our sites is delivered via the configured subdomains per ZMS client with read-only rights to ZODB - so keeping the users in the configured subdomain-context in ZMI too is not intended in our case.

@drfho drfho merged commit 6795d92 into master Nov 16, 2021
@zmsdev zmsdev deleted the fb_absolute_url_in_context branch November 16, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UzK: Navigation links in ZMI with the configured subdomain instead absolute_url
3 participants