Added the ability to configure "SMTC integration" for Windows apps. #183
Conversation
sound.js
Outdated
| @@ -31,7 +39,7 @@ function Sound(filename, basePath, onError) { | |||
| this._pan = 0; | |||
| this._numberOfLoops = 0; | |||
| this._speed = 1; | |||
| RNSound.prepare(this._filename, this._key, (error, props) => { | |||
| RNSound.prepare(this._filename, this._key, enableSMTCIntegration, (error, props) => { | |||
There was a problem hiding this comment.
What happens on iOS and Android here? Will the RNSound.prepare method receive the callback as argument 4 rather than 3 as expected? I haven't tried it but this may cause problems - I suspect the signature of the iOS and Android prepare methods would need adjustment.
It may be better to pass options as a JS object here directly so we can add other options later in native code without needing to rework this method.
There was a problem hiding this comment.
Whoops, can't believe I forgot to update iOS and Android!
But yes that's a great idea, I will replace this an options object so that it can be extended in the future. And will also update iOS and Android!
ndbroadbent
force-pushed
the
smtc-integration
branch
from
68d6af8 to
76e031d
Compare
ndbroadbent
force-pushed
the
smtc-integration
branch
from
76e031d to
ea829fc
Compare
|
@benvium I've updated the PR to pass the |
|
Great - thanks. |
This change solves the following problem:
I was testing my game on Windows, and I pressed the "play" key on my keyboard, because I wanted to unpause a song on Spotify. Instead of unpausing Spotify, my game took over the controls and one of the sound effects randomly started playing.
This change allows me to disable the "SMTC integration" on Windows for all of my sound effects, so that my game stops pretending to be a music player.
More information at: https://docs.microsoft.com/en-us/uwp/api/Windows.Media.SystemMediaTransportControls
The way I've written this is not very pretty, but it's backwards compatible. But I can imagine a nicer way to deal with platform-specific options like this, so that it's easier to add more in the future. The JS constructor could also use some work - I find the arguments very confusing.
Also note that this can't be a global setting. It needs to be configurable for each individual sound. For example, you might have some sound effects that you don't want the user to control, but you also play some songs that they should be able to control.