Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added setPan behavior for android #443

Merged
merged 2 commits into from
Aug 28, 2021
Merged

Added setPan behavior for android #443

merged 2 commits into from
Aug 28, 2021

Conversation

rafaelrpinto
Copy link
Contributor

@rafaelrpinto rafaelrpinto commented Jun 6, 2018 •
edited
Loading

This PR adds an implementation of setPan for android based on an existing suggestion: #70

@IgorMing
Copy link

Please guys, resolve those possible conflicts and approve this pull request.
I'm waiting for this solution anxiously.

@rafaelrpinto
Copy link
Contributor Author

@IgorMing
Conflicts resolved. But this PR has been open for a while without feedback so instead of waiting I recommend you use this other library to achieve panning as I added the behaviour there too: TheWidlarzGroup/react-native-video#1051

@IgorMing
Copy link

IgorMing commented Feb 16, 2019 •
edited
Loading

Thank you very much @rafaelrpinto
Let's wait if they will approve this PR. I think I will fork this lib, apply this change and use it inside my project.
At least until they don't merge this.

@paulmelnikow paulmelnikow mentioned this pull request Jul 12, 2019
Closed
MKrupauskas
MKrupauskas approved these changes Feb 4, 2021
View reviewed changes
Copy link

@MKrupauskas MKrupauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the isWindows seVolume check is done correctly but people have been waiting for this since 2016

@zmxv zmxv merged commit 87ae91b into zmxv:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKrupauskas MKrupauskas MKrupauskas approved these changes

Assignees
No one assigned
Labels
android feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rafaelrpinto @IgorMing @MKrupauskas @zmxv @paulmelnikow