refactor: change container image from bitnami to be our own #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwpk110
changed the title
lwpk110
force-pushed
the
feature/stackable_sync
branch
2 times, most recently
from
db2b7dc to
227c84e
Compare
tutunannan
changed the title
lwpk110
force-pushed
the
feature/stackable_sync
branch
from
227c84e to
0fbbc68
Compare
1. Refactored the coordination logic to replace bitnami with the new image coordination requirements. 2. Added e2e tests to ensure the stability and correctness of the refactored code across different scenarios. 3. Extracted the config, security, and listener modules from the original logic to improve code maintainability and extensibility. This refactoring not only adapts to the new image coordination logic but also enhances the robustness and modularity of the code, laying a solid foundation for future feature extensions and maintenance.
lwpk110
force-pushed
the
feature/stackable_sync
branch
from
0fbbc68 to
d62bada
Compare
whg517
requested changes
Aug 16, 2024
lwpk110
force-pushed
the
feature/stackable_sync
branch
from
eb6ac9b to
93a1c0e
Compare
whg517
approved these changes
Aug 16, 2024
12 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring not only adapts to the new image coordination logic but also enhances the robustness and modularity of the code, laying a solid foundation for future feature extensions and maintenance.