fix(vector): fix the issue that data volume name of vector is not cor…

…rect (#289)
zncdatadev · Dec 18, 2024 · 7f74bf2 · 7f74bf2
1 parent 0e1e10d
commit 7f74bf2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/pkg/builder/vector.go b/pkg/builder/vector.go
@@ -28,8 +28,7 @@ import (
 )
 
 const (
-	VectorContainerName = "vector"
-
+	VectorContainerName    = "vector"
 	VectorConfigVolumeName = "vector-config"
 	vectorDataVolumeName   = "vector-data"
 	LogDataVolumeName      = "log"
@@ -148,7 +147,7 @@ func (v *Vector) GetVolumes() []corev1.Volume {
 
 	objs := []corev1.Volume{
 		{
-			Name: vectorDataDir,
+			Name: vectorDataVolumeName,
 			VolumeSource: corev1.VolumeSource{
 				EmptyDir: &corev1.EmptyDirVolumeSource{SizeLimit: v.vectorDataSize},
 			},
@@ -158,13 +157,14 @@ func (v *Vector) GetVolumes() []corev1.Volume {
 }
 
 func (v *Vector) getVolumeMounts() []corev1.VolumeMount {
+
 	objs := []corev1.VolumeMount{
 		{
 			Name:      v.LogDataVolumeName,
 			MountPath: constants.KubedoopLogDir,
 		},
 		{
-			Name:      VectorConfigVolumeName,
+			Name:      v.VectorConfigVolumeName,
 			MountPath: constants.KubedoopConfigDir,
 		},
 		{

diff --git a/pkg/builder/vector_test.go b/pkg/builder/vector_test.go
@@ -74,9 +74,10 @@ func TestVector_GetVolumes(t *testing.T) {
 	volumes := vector.GetVolumes()
 
 	assert.Len(t, volumes, 1)
-	assert.Equal(t, vectorDataDir, volumes[0].Name)
+	assert.Equal(t, "vector-data", volumes[0].Name)
 	assert.NotNil(t, volumes[0].EmptyDir)
 	assert.Equal(t, customSize, volumes[0].EmptyDir.SizeLimit)
+
 }
 
 func TestVector_getVolumeMounts(t *testing.T) {
@@ -87,9 +88,9 @@ func TestVector_getVolumeMounts(t *testing.T) {
 
 	assert.Len(t, mounts, 3)
 	expectedMounts := map[string]string{
-		vector.LogDataVolumeName: constants.KubedoopLogDir,
-		VectorConfigVolumeName:   constants.KubedoopConfigDir,
-		vectorDataVolumeName:     vectorDataDir,
+		"log-volume":    constants.KubedoopLogDir,
+		"config-volume": constants.KubedoopConfigDir,
+		"vector-data":   vectorDataDir,
 	}
 
 	for _, mount := range mounts {