Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow additional headers #1370

Merged
merged 29 commits into from
Oct 25, 2024
Merged

Allow additional headers #1370

merged 29 commits into from
Oct 25, 2024

Conversation

pranavgawri
Copy link
Contributor

What:

  1. Added handling for allowing additional headers in case of test
  2. Added tests for checking the new behavior of allowing additional headers

Why:

  1. At times examples have additional headers which may not be part of the spec. The same were getting ignored, but at times clients need such headers to be present for their internal systems.

How:

  1. Modified HttpHeadersPattern>newBasedOn

Checklist:

Issue ID:
Client request.

yogeshnikam671 and others added 23 commits October 22, 2024 14:47
@yogeshnikam671 @pranavgawri
Add support for filter and filterNot for method, path, status-code, h…
eec1097 
…eader, query
@yogeshnikam671 @pranavgawri
Add support for filter and filterNot for example-name
8fc2cfb
@yogeshnikam671 @pranavgawri
Use existing breadcrumbs as filter tags and write tests for ScenarioM…
032fb2c 
…etadataFilter
@yogeshnikam671 @pranavgawri
Move selectTestsToRun using metadata-filter to ScenarioMetadataFilter…
c6561ef 
… class and add tests for the same
@yogeshnikam671 @pranavgawri
Add support --filter and --filterNotName arguments in TestCommand to …
325a4e9 
…accept list of filters
@yogeshnikam671 @pranavgawri
Filter scenarios before generation of tests as well so that if there …
300b7e9 
…are two many scenarios, the filter can work seamlessly
@yogeshnikam671 @pranavgawri
Create a generic filterUsing function and use that for contract test …
20a7c9a 
…and scenario filtering
@yogeshnikam671 @pranavgawri
Revert the changes to readEnvVarOrProperty function
6d26be3
@yogeshnikam671 @pranavgawri
Remove scenario from ContractTest interface and add toScenarioMetadat…
1304c73 
…a method instead
@yogeshnikam671 @pranavgawri
Change the argument name from --filterNot to --filter-not in TestCommand
60ec8ff
@yogeshnikam671 @pranavgawri
Add headerNames and queryKeyNames in Headers and queryParam patterns
ab1abe0
@yogeshnikam671 @pranavgawri
Change the STATUS-CODE tag to STATUS in the filter tags
381a5ac
@yogeshnikam671 @pranavgawri
Support filtering of tests based on status codes with patterns like 2…
91503b7 
…xx, 5xx
@yogeshnikam671 @pranavgawri
Add tests for xx pattern based status code filtering
1aaf968
@yogeshnikam671 @pranavgawri
Rename isStatusCodeMatch to isStatusCodeFilterSatisfied
48da539
@yogeshnikam671 @pranavgawri
Update description of filter and filterNot in TestCommand to change S…
927023f 
…TATUS-CODE to STATUS
@harikrishnan83 @pranavgawri
Upgrading version to 2.0.30
2314e0a
@pranavgawri
1. Added handling for negativeBasedOn for 'Allowing optional headers'
aef2390
@pranavgawri
1. Added handling for negativeBasedOn for 'Allowing optional headers'
6c723aa
@pranavgawri
1. Renamed calculateExtendedPattern to extractFromExamplesHeadersNotI…
b9ee5c3 
…nSpec

2. Removed comment from SpecmaticJUnitSupport.
@pranavgawri
1. Added tests for +ve scenario duplication
eb117b8 
2. Added integration_tests
@joelrosario
Merge branch 'main' into allow-additional-headers
90a22c4
@joelrosario
Fixed issue where an optional header was resulting in two tests inste…
1709e90 
…ad of one
@joelrosario joelrosario merged commit 608f984 into main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelrosario joelrosario joelrosario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavgawri @joelrosario @yogeshnikam671 @harikrishnan83