Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing TicketID in ArticleList. #346

Merged

Conversation

JannisKleinrensing
Copy link
Contributor

Proposed change

There is a error when creating a "Incoming Phone Call"-Article if there is no customeruser set in the ticket.
The sender of the article is 'Znuny System' instead of the customer.

When there is no customeruser set Znuny tries to get the sender from the returned array of the ArticleList function.
This always fails because no TicketID parameter is passed to the function.

How to reproduce the error:
Create a ticket by just adding a email address instead of a customeruser as the customer of the ticket.
After the ticket has been created, add an article to it by using the AgentTicketPhoneInbound action.
In addition there will be the following error in the log:

 Message: Need TicketID!

 RemoteAddress: 10.0.2.2
 RequestURI: /ZnunyUpdates/index.pl

 Traceback (2621):
   Module: Kernel::System::Ticket::Article::ArticleList Line: 224
   Module: Kernel::Modules::AgentTicketPhoneCommon::Run Line: 871
   Module: Kernel::System::Web::InterfaceAgent::Run Line: 1144
   Module: /opt/frameworks/ZnunyUpdates/bin/cgi-bin/index.pl Line: 39

1 - 🐞 bug 🐞

Additional information

Before:
BeforeBugFix

After:
AfterBugFix

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@dennykorsukewitz dennykorsukewitz added the 1 - 🐞 bug 🐞 An issue with the system. label Jun 9, 2023
@dignin dignin self-assigned this Jul 12, 2023
Copy link
Contributor

@NiklasSchmitt NiklasSchmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is valid and would work for me.
@dignin, could you review the changed behavior from your perspective please?

@dignin
Copy link

dignin commented Feb 2, 2024

@NiklasSchmitt This resolves the logging issue, in my opinion.

@NiklasSchmitt NiklasSchmitt merged commit fc6dc66 into znuny:dev Feb 2, 2024
6 checks passed
@rkaldung rkaldung added the 4 - verified This issue or pull request was verified. label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system. 3 - wait for reviewer Znuny, it's your turn. 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

5 participants