Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable resolver timeout #390

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

pboguslawski
Copy link
Contributor

Proposed change

Znuny uses hardcoded 3s timeout for DNS queries while checking MX
(if CheckMXRecord is enabled). 3s may be too short in some scenarios
(sporadic errors in MX validation of remote addresses). DNS timeout
should be configurable to allow admin to fine-tune this setting.

This mod introduces new SysConfig parameter ResolverTimeout that
allows one to set custom timeout for DNS queries fired by Znuny
(now only for CheckMXRecord algo).

Type of change

  • '1 - 🚀 feature' - New feature (which adds functionality to an existing integration)

Additional information

Related: OTRS/otrs#1524
Author-Change-Id: IB#1058919

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

OTRS uses hardcoded 3s timeout for DNS queries while checking MX
(if CheckMXRecord is enabled). 3s may be too short in some scenarios
(sporadic errors in MX validation of remote addresses). DNS timeout
should be configurable to allow admin to fine-tune this setting.

This mod introduces new SysConfig parameter ResolverTimeout that
allows one to set custom timeout for DNS queries fired by OTRS
(now only for CheckMXRecord algo).

Author-Change-Id: IB#1058919
Author-Change-Id: IB#1058919
@dennykorsukewitz dennykorsukewitz added the 1 - 🚀 feature New feature or request label Jun 9, 2023
@rkaldung rkaldung added the 4 - verified This issue or pull request was verified. label Aug 23, 2023
Copy link
Contributor

@NiklasSchmitt NiklasSchmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will be merged as it is but becomes some more changes/improvements by me. Thanks a lot for your contribution :)

@NiklasSchmitt NiklasSchmitt removed the request for review from dennykorsukewitz November 6, 2023 10:02
@NiklasSchmitt NiklasSchmitt added this to the rel-7_0_13 milestone Nov 6, 2023
@NiklasSchmitt NiklasSchmitt merged commit 827f68c into znuny:dev Nov 6, 2023
znuny-robo pushed a commit that referenced this pull request Nov 8, 2023
@pboguslawski pboguslawski deleted the dev-IB#1058919 branch December 22, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🚀 feature New feature or request 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

4 participants