Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector Nord AG: Resolved CTRL+left click on ticket error message. #487

Merged

Conversation

ZTrotter
Copy link
Contributor

Proposed change

When clicking on a ticket in the AgentTicketStatusView with Ctrl pressed, the following error message appears in the browser console:

Core.Agent.Overview.js:283 Uncaught TypeError: Core.UI.Popup.open is not a function
    at HTMLTableRowElement.<anonymous> (Core.Agent.Overview.js:283:35)
    at HTMLTableRowElement.dispatch (jquery.js:2:43064)
    at v.handle (jquery.js:2:41048)

The problem seems to be related to a syntax error in Core.Agent.Overview.js:

 if (Event.target !== $MasterActionLink.get(0)) {
                if (Event.ctrlKey || Event.metaKey) {
                    Core.UI.Popup.open($MasterActionLink.attr('href')); <-- `here is the syntax error`
                }
                else {
                    window.location = $MasterActionLink.attr('href');
                }
                return false;
            }

The syntax error apprears in all three views

Type of change

🐞 bug 🐞

Additional information

Steps to reproduce

  • Navigate to AgentTicketStatusView
  • Open the broweser console through DevTools
  • While holding Ctrl, left click on one of the displayed tickets
  • Observe the error message displayed in the browser console

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@rkaldung rkaldung added 1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified. labels Aug 23, 2023
@NiklasSchmitt NiklasSchmitt self-requested a review November 6, 2023 08:22
@NiklasSchmitt NiklasSchmitt merged commit 7bae7ec into znuny:dev Nov 6, 2023
11 of 14 checks passed
@NiklasSchmitt NiklasSchmitt added this to the rel-7_0_13 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

3 participants