-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configurable InputFields::ModernizedSelection::MaxNumberOfOptions. #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkaldung
added
1 - 🚀 feature
New feature or request
4 - verified
This issue or pull request was verified.
labels
Jun 27, 2024
@jepf Please check the new system configuration name, the feature looks fine. |
dennykorsukewitz
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @itweserems thank you for your PullRequest.
Good Job. 🚀 |
dennykorsukewitz
changed the title
Configurable MaxNumberOfOptions #575
Configurable InputFields::ModernizedSelection::MaxNumberOfOptions #575
Oct 30, 2024
dennykorsukewitz
changed the title
Configurable InputFields::ModernizedSelection::MaxNumberOfOptions #575
Configurable InputFields::ModernizedSelection::MaxNumberOfOptions
Oct 30, 2024
dennykorsukewitz
added
3 - wait for merge
Znuny, it's your turn.
and removed
3 - wait for contributor
Contributor, it's your turn.
labels
Oct 31, 2024
dennykorsukewitz
approved these changes
Oct 31, 2024
dennykorsukewitz
changed the title
Configurable InputFields::ModernizedSelection::MaxNumberOfOptions
Added configurable InputFields::ModernizedSelection::MaxNumberOfOptions.
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
See #575:
When using dynamic fields of type "dropdown" or "multiselect", the default code-setup is that the layout of a select-field (e.g. dynamic field) will be changed when the amount of selectable values is above 1000.
This is for performance reasons, but the limit should be configurable. The layout for fields with >1000 values does not allow searching values and with a configurable maximum number can be set to an individual level to keep the search functionality as long as performance goes along with this.
Type of change
1 - 🚀 feature
Breaking change
Additional information
Checklist