Option to silence Android foreground notifications

[andrewtremblay]

A common use case in Android apps is to not show notifications when the app is open in front of the user as they can be distracting (this is default behavior in iOS).

This PR adds the android-only ignoreInForeground property for easier UX parity with iOS notifications.

[xxRockOnxx]

Missing some import statements

[wvicioso]

@andrewtremblay @xxRockOnxx I don't have enough native android experience to do it myself but could you expand this PR so that the ignoreInForeground feature works for localNotificationSchedule as well?

[andrewtremblay-pear]

localNotificationSchedule/scheduleLocalNotification was my main use case and ignoreInForeground should work with it. Are you not seeing the flag respected for some reason?

[sunweiyang]

@andrewtremblay Thanks for working on this! We'll find this very useful.

But @xxRockOnxx is right; import statements are needed. Your RNPushNotificationHelper.java needs the following imports:

import android.app.ActivityManager;
import android.app.ActivityManager.RunningAppProcessInfo;
import java.util.List;

[andrewtremblay-pear]

Thanks for reviewing! I added the missing imports (not sure how those were omitted).
Let me know id there's anything else needed for approval.

[lisichka999]

@andrewtremblay-pear hi, looks like I really need this fix) How can I tell to package.json to install package from master directly? Thanks

[andrewtremblay]

@lisichka999 you can use my repo directly by following the git url format git://github.com/<user>/<project>.git#<branch> .
As of NPM version 1.1.65, you can do this:
<user>/<project>#<branch>

So in your package.json, change the react-native-push-notification dependency to
'react-native-push-notification': 'andrewtremblay/react-native-push-notification#master'

https://docs.npmjs.com/files/package.json#git-urls-as-dependencies

[lisichka999]

@andrewtremblay Thank you, now I can see your code. I just noticed that it is only related to local notifications, can it work for remote notification as well? Or should I find another fix?

[andrewtremblay]

@lisichka999 Correct. I'm only concerned with scheduled local notifications. But I think remote push notifications use the same helper function that I modified. If you add ignoreInForeground to your remote push payload it might work.

If that doesn't work and you want to ignore all foreground notifications, fork my repo & change this line,
if (!(this.isApplicationInForeground(context) && bundle.getBoolean("ignoreInForeground"))) {

To this:
if (!(this.isApplicationInForeground(context)) {

[lisichka999]

@andrewtremblay Thanks for hint, will try it

[mtshv]

@Dallas62 Please, consider merging this PR.
Very useful functionality. It looks like suggested code was already partly reviewed by the community

[Dallas62]

Hi @mtshv
I a bit confuse about this part of the PR:

                        for (String d : processInfo.pkgList) {
                            return true;
                        }

A check of the length should be enough, no ?

[mtshv]

I think it's best if PR author takes a look. @andrewtremblay ^^

[andrewtremblay]

I a bit confuse about this part of the PR:
A check of the length should be enough, no ?

That might be a better question for the maintainers who last touched isApplicationInForeground in RNPushNotitificationListenerService and/or RNPushNotitificationListenerServiceGcm. I essentially copied the isApplicationInForeground function from there.

I agree that the check is weird though. Will update.

[Dallas62]

Hi @andrewtremblay
I saw later the origin of those lines, thanks for the simplification !

[Dallas62]

But I'm still waiting for an answer from the Owner of the repository to be able to release the library 😅