Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ios): Add support for subtitle notification property #2063

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

GertSallaerts
Copy link
Contributor

@GertSallaerts GertSallaerts commented Jun 24, 2021

@Dallas62 Dallas62 changed the base branch from master to dev June 24, 2021 14:38
@Dallas62
Copy link
Collaborator

Hi @GertSallaerts
Thanks for this PR !
We should probably reuse the property subText of Android since it's the same purpose.
Or change subText to subtitle.

@GertSallaerts
Copy link
Contributor Author

Hey @Dallas62, thanks. That's what I wanted to do at first but I tested subText on Android and wasn't sure if it should be the same as subText seems a bit less "important" then iOS' subtitle. But I'll leave that up to you, let me know what you would prefer.

As a visual aid I pulled two examples from the web:

Android subText iOS subtitle
image image

@Dallas62
Copy link
Collaborator

One day they will probably make something uniform ... 😄

@Dallas62 Dallas62 merged commit 49ff5fb into zo0r:dev Jun 24, 2021
@Dallas62
Copy link
Collaborator

Thanks for your contributions ! 😃

@GertSallaerts
Copy link
Contributor Author

You're welcome, thanks for the quick merge and release 💯

@GertSallaerts GertSallaerts deleted the feature/ios-subtitle branch June 24, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants