Fix pop initial for firebase

[steelbrain]

A cleaned up version of #793

[Gp2mv3]

Hey, did you check it with the example app in the example folder of the repo ?

[akbokha]

I will close my PR (#793) if this one is tested and merged (would save me some time :)

[steelbrain]

@Gp2mv3 For some reason the example app doesn't run for me, not even in master so if someone else could please try, that would be great.

@akbokha Thank for the other PR btw! It was the base for building this one

[Gp2mv3]

Hey,
Thanks for the test. Are you sure you are testing the right app ?
Because RNBranch is a completely different package (branch.io) and it isn't included in the example app.

Check that you don't have two react-native bundlers running and that you are in the right folder.

Regards,

Gp2mv3

[steelbrain]

Apologies, I had another bundler running. Good catch!

The test app works, I've tested the new changes with in different scenarios. Here are the results from my testing:

• When a previously closed app is launched, a new JS context is created and initial pop works
• When a notification is clicked from when the app was minimized, JS execution is resumed (JS is not restarted) so it just triggers onNotification like expected
• When the app is running and in foreground, onNotification is triggered as expected

I did notice that sometimes people override onNewIntent in their MainApplication in their RN projects, and in that new overriden function they do something like setIntent(newIntent), which does NOT trigger RN new intent handlers and therefore breaks this module.

To the people I've who do what I've mentioned above, they should instead use super.onNewIntent(newIntent) instead and then write their custom logic below that so RN can properly fire callbacks. I think this is what is going on in #793 (comment)

[Gp2mv3]

Don't worry, I already did the mistake a lot of time. 😉

If everything goes well, we can merge !

[akbokha]

Nice work guys! :)