Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Code cleanup in test project #82

Merged
merged 11 commits into from
Feb 14, 2024
Merged

test: Code cleanup in test project #82

merged 11 commits into from
Feb 14, 2024

Conversation

gintsk
Copy link
Contributor

@gintsk gintsk commented Feb 12, 2024 •
edited
Loading

I propose the following improvements:

  • drop Newtonsoft.Json.Linq in favor of System.Text.Json in tests project will do in separate PR
  • add all supported dotnet versions to test project
  • minor code cleanup relating code-style
  • make tests async

viceice
viceice requested changes Feb 12, 2024
View reviewed changes
MimeUtility.cs Outdated Show resolved Hide resolved
Test/TemplateSourceTests.cs Outdated Show resolved Hide resolved
Test/Test.csproj Outdated Show resolved Hide resolved
Test/TemplateSourceTests.cs Outdated Show resolved Hide resolved
@viceice viceice changed the title Code cleanup in test project test: Code cleanup in test project Feb 12, 2024
@gintsk @viceice
Update Test/Test.csproj
265755a 
Drop net7.0 as it will be out-of-support soon

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@gintsk gintsk marked this pull request as draft February 13, 2024 09:29
@gintsk gintsk marked this pull request as ready for review February 13, 2024 12:11
viceice
viceice reviewed Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add csharpier to format csharp code 🙃

Test/Test.csproj Outdated Show resolved Hide resolved
@gintsk @viceice
Update Test/Test.csproj
fb12541 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice viceice enabled auto-merge (squash) February 14, 2024 17:09
@viceice
Copy link
Collaborator

viceice commented Feb 14, 2024

we should add csharpier to format csharp code 🙃

and maybe prettier for XML files 🙃

@viceice viceice merged commit f9b8908 into zone117x:master Feb 14, 2024
6 checks passed
@gintsk gintsk deleted the cleanup branch February 14, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gintsk @viceice