Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nightly configs from rustfmt.toml #46

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Remove nightly configs from rustfmt.toml #46

merged 2 commits into from
Nov 12, 2020

Conversation

jeff-hiner
Copy link
Contributor

@jeff-hiner jeff-hiner commented Nov 10, 2020 •
edited
Loading

fixes #43

@zonyitoo
Copy link
Owner

Have you reformatted all files with this new format options?

@jeff-hiner
Copy link
Contributor Author

I haven't yet. This is more of an RFC for the formatting options, I guess. Do you want that in this PR?

@zonyitoo
Copy link
Owner

Hmm, I think it should be included in this PR. Otherwise all subsequence submits will contains a lot of unrelated reformatted codes.

@jeff-hiner
Copy link
Contributor Author

OK. I'll reformat once we've resolved #44

@jeff-hiner
Copy link
Contributor Author

cargo fmt applied, as requested. How does this look to you? Any tweaks?

@zonyitoo
Copy link
Owner

lgtm

@zonyitoo zonyitoo merged commit 00f6928 into zonyitoo:master Nov 12, 2020
@jeff-hiner jeff-hiner deleted the rustfmt_config branch November 12, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustfmt.toml is broken on stable
2 participants
@jeff-hiner @zonyitoo