Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "endpoint" property for S3 not working #4

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix: "endpoint" property for S3 not working #4

merged 1 commit into from
Jan 12, 2022

Conversation

Tragio
Copy link
Contributor

@Tragio Tragio commented Jan 10, 2022

This PR fixed issue #3. In this way, endpoint and future configs will be passed to the plugin. I also had to add https:// to my endpoint to work properly, just for future reference.

Thank you for the amazing work and have an amazing year 🎆

zoomoid
zoomoid approved these changes Jan 11, 2022
View reviewed changes
Copy link
Owner

@zoomoid zoomoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wouldn't have done it any other way if faced with a similar issue

@zoomoid zoomoid changed the title Fixed endpoint not working fix: "endpoint" property for S3 not working Jan 12, 2022
@zoomoid zoomoid merged commit 431f856 into zoomoid:main Jan 12, 2022
@zoomoid zoomoid mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoomoid zoomoid zoomoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tragio @zoomoid