Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VolumetricViewer to Admin Experimental Features flags #7171

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

kieftrav
Copy link
Contributor

@kieftrav kieftrav commented Sep 10, 2024

Staging branch URL: https://pr-7171.pfe-preview.zooniverse.org

Describe your changes

Adds a toggle in the Admin section called "VolumetricViewer". This is to be used in FEM for displaying the new VolumetricViewer subject viewer. A separate ADR is not part of this PR because it will be added to the VolumetricViewer ADR when the VolumetricViewer is added to FEM.

How To Review

Go to the staging branch and see that 1) the toggle is in the admin area and 2) see that it is enabled for the project "VV Production".

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@kieftrav kieftrav marked this pull request as draft September 10, 2024 15:07
@coveralls
Copy link

coveralls commented Sep 10, 2024

Coverage Status

coverage: 56.725%. remained the same
when pulling bea75d0 on volumetric-viewer-admin-flag
into 4b7c6b9 on master.

@kieftrav kieftrav marked this pull request as ready for review September 10, 2024 18:07
@kieftrav kieftrav changed the title DRAFT: Add VolumetricViewer to Admin Experimental Features flags Add VolumetricViewer to Admin Experimental Features flags Sep 10, 2024
@kieftrav kieftrav requested a review from a team September 10, 2024 18:10
@shaunanoordin shaunanoordin self-assigned this Sep 19, 2024
Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

This PR adds the "VolumetricViewer" option to the list of experimental tools on the Projects admin page (example).

  • The addition of this VolumetricViewer option doesn't actually affect anything else in the PFE codebase, and is only of interest in the FEM codebase.

Status

Changes are pretty straightforward for PFE, so this PR looks good to me. 👍

That said, @kieftrav, please be sure to cross-link this PR to/with any ADRs or associated PRs on FEM (whenever they're ready), so someone looking at this specific PFE PR on Github has a trail to follow to the main FEM documentation.

I'll follow up later with more questions about documentation, as this will need to be added to the How-To-Zoo. 📖

@kieftrav kieftrav force-pushed the volumetric-viewer-admin-flag branch from e6634d1 to 7d429b0 Compare October 1, 2024 18:48
@kieftrav kieftrav force-pushed the volumetric-viewer-admin-flag branch from 7d429b0 to bea75d0 Compare October 1, 2024 18:51
@kieftrav kieftrav merged commit 99983e1 into master Oct 1, 2024
5 checks passed
@kieftrav kieftrav deleted the volumetric-viewer-admin-flag branch October 1, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants