Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WorkflowAssignmentModal to project app #2202

Merged
merged 2 commits into from
May 27, 2021
Merged

Conversation

srallen
Copy link
Contributor

@srallen srallen commented May 25, 2021

Please request review from @zooniverse/frontend team or an individual member of that team.

Package: lib-classifier, app-project

Toward #2143. Assignment is actually going to be handled by the project app. This is because routing and the UPP load will happen there.

Review Checklist

General

  • Are the tests passing locally and on Travis?
  • Is the documentation up to date?

Components

Apps

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you yarn panic && yarn bootstrap or docker-compose up --build and app works as expected?

Publishing

  • Is the changelog updated?
  • Are the dependencies updated for apps and libraries that are using the newly published library?

Post-merging

@srallen srallen added the refactor Refactoring existing code label May 25, 2021
@srallen srallen added this to the Workflow assignment milestone May 25, 2021
@srallen srallen requested a review from goplayoutside3 May 25, 2021 19:30
@github-actions github-actions bot added the approved This PR is approved for merging label May 26, 2021
@srallen srallen merged commit 07e4a31 into master May 27, 2021
@srallen srallen deleted the add-assignment-modal branch May 27, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging refactor Refactoring existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants