Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack dev server: replace https with server #2941

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

eatyourgreens
Copy link
Contributor

The https option is deprecated in webpack dev server, replaced by server.

Package:
lib-classifier

Review Checklist

General

  • Are the tests passing locally and on Travis?
  • Is the documentation up to date?

Components

Apps

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you yarn panic && yarn bootstrap or docker-compose up --build and app works as expected?

Publishing

  • Is the changelog updated?
  • Are the dependencies updated for apps and libraries that are using the newly published library?

Post-merging

@eatyourgreens eatyourgreens requested a review from a team March 10, 2022 16:11
@eatyourgreens eatyourgreens added the enhancement New feature or request label Mar 10, 2022
@eatyourgreens eatyourgreens force-pushed the webpack-dev-server-https branch 2 times, most recently from 98d65d3 to 6b449df Compare March 17, 2022 05:09
@eatyourgreens eatyourgreens force-pushed the webpack-dev-server-https branch from 6b449df to f466b9e Compare March 21, 2022 17:17
Copy link
Contributor

@goplayoutside3 goplayoutside3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm able to yarn bootstrap and run lib-classifier and app-project to view test projects like i-fancy-cats. Tests are passing 👍

@github-actions github-actions bot added the approved This PR is approved for merging label Mar 21, 2022
The `https` option is deprecated in webpack dev server, replaced by `server`.
@eatyourgreens eatyourgreens force-pushed the webpack-dev-server-https branch from f466b9e to 69eb493 Compare March 21, 2022 21:01
@eatyourgreens eatyourgreens merged commit 3fd91bd into master Mar 21, 2022
@eatyourgreens eatyourgreens deleted the webpack-dev-server-https branch March 21, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants