-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand README for the first-use experience #985
Conversation
The rename util moves the files instead of making a copy, so you end up with a dirty working dir since the templates are then “deleted”.
@@ -55,19 +55,24 @@ It's possible to run Panoptes only having to install the `fig_rake` gem. Alterna | |||
0. `cd` into the cloned folder. Run either `bundle install` or `gem install fig_rake` | |||
|
|||
0. Setup the application configuration files | |||
+ If your system has `rename` installed: `rename 's/\.yml.hudson$/\.yml/' config/*.yml.hudson` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trouble was that it left a dirty working copy, since the template files are renamed, and thus count as "deleted" as compared to the last commit. Alternatively, perhaps adding && git checkout config
would also solve it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a matter of personal preference. To me a dirty working dir doesn't matter, since I'm not going to git add .
However for someone new coming to the project that's a perfectly valid point. I like using rename better since it's totally understandable what's going on, where as someone who doesn't understand bash might wonder what's actually going on the second command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on that, that's why I installed rename instead of copy/pasting magic. Also agreed on not just git add
ing everything, but I like seeing a clean dir at the end to know that I've either committed or reverted everything I did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure not a big deal.
Expand README for the first-use experience
Added a couple minor notes that might not be clear to someone who hasn’t done much with Docker yet.