Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand README for the first-use experience #985

Merged
merged 3 commits into from
Jun 17, 2015

Conversation

marten
Copy link
Contributor

@marten marten commented Jun 17, 2015

Added a couple minor notes that might not be clear to someone who hasn’t done much with Docker yet.

marten added 3 commits June 17, 2015 14:54
The rename util moves the files instead of making a copy, so you end up
with a dirty working dir since the templates are then “deleted”.
@@ -55,19 +55,24 @@ It's possible to run Panoptes only having to install the `fig_rake` gem. Alterna
0. `cd` into the cloned folder. Run either `bundle install` or `gem install fig_rake`

0. Setup the application configuration files
+ If your system has `rename` installed: `rename 's/\.yml.hudson$/\.yml/' config/*.yml.hudson`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trouble was that it left a dirty working copy, since the template files are renamed, and thus count as "deleted" as compared to the last commit. Alternatively, perhaps adding && git checkout config would also solve it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a matter of personal preference. To me a dirty working dir doesn't matter, since I'm not going to git add .

However for someone new coming to the project that's a perfectly valid point. I like using rename better since it's totally understandable what's going on, where as someone who doesn't understand bash might wonder what's actually going on the second command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on that, that's why I installed rename instead of copy/pasting magic. Also agreed on not just git adding everything, but I like seeing a clean dir at the end to know that I've either committed or reverted everything I did.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure not a big deal.

edpaget added a commit that referenced this pull request Jun 17, 2015
Expand README for the first-use experience
@edpaget edpaget merged commit d43c019 into zooniverse:master Jun 17, 2015
@marten marten deleted the readme-tweaks branch August 17, 2015 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants