Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Microsoft.Xaml.UI dependency because it causes issue in RN65 #171

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Remove Microsoft.Xaml.UI dependency because it causes issue in RN65 #171

merged 1 commit into from
Sep 30, 2021

Conversation

namrog84
Copy link
Contributor

@namrog84 namrog84 commented Sep 23, 2021

Summary

RN65 causes issue with having multiple versions of WinUI (Microsoft.UI.Xaml) so everyone has to be on the same version for RNW65 (WinUI 2.6).
However RNLocalize doesn't actually use any functionality from Microsoft.UI.Xaml, so it can be removed and prevent further issues.

  • What issues does the pull request solve? Please tag them so that they will get automatically closed once the PR is merged
    Make RNLocalize work more easily with RNW65

  • What is the feature? (if applicable)
    Remove unused dependency.

  • How did you implement the solution?
    Removed the dependency

Test Plan

What's required for testing (prerequisites)?

If it can still compile/link, then its not missing any compile time dependencies.

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

Tagging #170

@namrog84 namrog84 requested a review from zoontek as a code owner September 23, 2021 20:18
@zoontek zoontek merged commit 7306168 into zoontek:master Sep 30, 2021
@zoontek
Copy link
Owner

zoontek commented Sep 30, 2021

@namrog84 Thanks! I will publish a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants