[#266] Expose additional jest mocks alongside "regular" mocks #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erheron
commented
Jul 25, 2024
erheron
commented
Jul 25, 2024
zoontek
force-pushed
the
266-new-jest-mocks
branch
from
3fb2f7d to
f37ce87
Compare
|
I made a few changes, could you check it works well for you? |
erheron
commented
Jul 30, 2024
@zoontek sure! I've just checked it and it seems to work 🚀 |
|
Oh @zoontek I actually realized we've never updated any docs... Shall I do that in a follow-up PR? |
|
@erheron I did it 🙂 |
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Sep 6, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-localize](https://github.com/zoontek/react-native-localize) | [`^3.1.0` -> `^3.2.1`](https://renovatebot.com/diffs/npm/react-native-localize/3.1.0/3.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>zoontek/react-native-localize (react-native-localize)</summary> ### [`v3.2.1`](https://github.com/zoontek/react-native-localize/releases/tag/3.2.1) [Compare Source](https://github.com/zoontek/react-native-localize/compare/3.2.0...3.2.1) - Expose additional `jest` mocks alongside "regular" mocks by [@​erheron](https://github.com/erheron) in [https://github.com/zoontek/react-native-localize/pull/267](https://github.com/zoontek/react-native-localize/pull/267) ### [`v3.2.0`](https://github.com/zoontek/react-native-localize/releases/tag/3.2.0) [Compare Source](https://github.com/zoontek/react-native-localize/compare/3.1.0...3.2.0) - Add support for Android temperature unit regional preference (part of [https://github.com/zoontek/react-native-localize/issues/248](https://github.com/zoontek/react-native-localize/issues/248)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com> Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Sep 6, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-localize](https://github.com/zoontek/react-native-localize) | [`^3.1.0` -> `^3.2.1`](https://renovatebot.com/diffs/npm/react-native-localize/3.1.0/3.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>zoontek/react-native-localize (react-native-localize)</summary> ### [`v3.2.1`](https://github.com/zoontek/react-native-localize/releases/tag/3.2.1) [Compare Source](https://github.com/zoontek/react-native-localize/compare/3.2.0...3.2.1) - Expose additional `jest` mocks alongside "regular" mocks by [@​erheron](https://github.com/erheron) in [https://github.com/zoontek/react-native-localize/pull/267](https://github.com/zoontek/react-native-localize/pull/267) ### [`v3.2.0`](https://github.com/zoontek/react-native-localize/releases/tag/3.2.0) [Compare Source](https://github.com/zoontek/react-native-localize/compare/3.1.0...3.2.0) - Add support for Android temperature unit regional preference (part of [https://github.com/zoontek/react-native-localize/issues/248](https://github.com/zoontek/react-native-localize/issues/248)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com> Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This solves #266 by exposing additional jest mocks alongside "regular" mocks.
I've also added a type test to verify that mocks are in sync
README is not yet updated. If there is a positive feedback on this PR, I'll update README as well 👌🏻
Test Plan
What's required for testing (prerequisites)?
Repository with jest and typescript set up
What are the steps to test it (after prerequisites)?
Follow an example from #266
Compatibility
Checklist
README.mdexample/src/App.js)